Tapping on search button doesn’t dismiss FIP |
||||||
Issue descriptionApp Version: 67.0.3489.0 Canary iOS Version: 10.3.3, 11.4, 12 Beta 3 Device: iPhone Steps to reproduce: 1. Launch chrome 2. Load any webpage 3. Open find in page and search for any keyword 4. Tap on search icon in the bottom tool bar Observed results: Notice that keyboard displays without dismissing the find in page Expected results: Find in page should be dismissed and omnibox should be focused Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes/No Bug reproducible after clearing cache and cookies: Yes/No Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M67 (happens only in UI Refresh) Bug reproducible on the current beta channel build (App Version, iOS Version): No on M68 (happens only in UI Refresh) Link to video: https://drive.google.com/file/d/1wBr3VRdhCfCfWHo0XB6bJCTxRYpzTHH-/view?usp=sharing
,
Jul 13
Keep this as a P2 since user can still dismiss FIP by hitting x
,
Jul 16
This was reported in 67; is it UI-refresh specific? Removing milestone since this is a P2
,
Aug 14
,
Aug 20
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce03043473691f9cf74246adbc85dce6c8a69c5a commit ce03043473691f9cf74246adbc85dce6c8a69c5a Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Mon Aug 20 13:30:47 2018 [iOS] Make omnibox accelerator button close find in page. Makes the accelerator omnibox button in the bottom toolbar dismiss the find in page popup on press. Bug: 863002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic293d90856a10d08c50edf8987c3eb4838c2c395 Reviewed-on: https://chromium-review.googlesource.com/1181046 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584425} [modify] https://crrev.com/ce03043473691f9cf74246adbc85dce6c8a69c5a/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
,
Aug 20
,
Aug 29
Verified the issue on the build version 70.0.3535.0 canary tested on iPhone(iOS 11.4.1). Find in page is dismissed and omnibox is focused. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 12Components: UI>Browser>Omnibox
Labels: M-69
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Summary: Tapping on search button doesn’t dismiss FIP (was: Tapping on search button doesn’t dismiss omnibox)