New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862980 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 862978
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

BP slides over function

Reported by sandroto...@googlemail.com, Jul 12

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Steps to reproduce the problem:
1. Open file "example.html" (see attached)
2. Set BPs as shown in "devtools_latest.mkv" (see attached)

What is the expected behavior?
The BP that is set in line 7 should be moved to line 8.

What went wrong?
The BP is moved to the next statement after the function instead of inside the function. This is inconsistent with the behavior of functions created via variables.

Did this work before? Yes 

Chrome version: 69.0.3490.0  Channel: dev
OS Version: Arch Linux x64
Flash Version: n/a

Possibly related to #784852 and maybe caused by #856665.
 
devtools_latest.mkv
143 KB Download
example.html
266 bytes View Download
Labels: Needs-Triage-M69 Needs-Bisect
Cc: kozyatinskiy@chromium.org vamshi.kommuri@chromium.org
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET M-69 RegressedIn-69 hasbisect Target-69 FoundIn-69 OS-Mac OS-Windows Pri-1
Owner: kozy@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported version 69.0.3490.0 using Ubuntu 14.04, Windows 10 and Mac 10.13.1
From  Issue 856665  mentioned in comment#0 checked for manual good/bad(as per reporter's view i.e.,where the change has made)

Bisect Information:
---------------------
Good Build: 69.0.3474.0
Bad Build:  69.0.3475.0

Assuming that, this behaviour is seen from 69.0.3475.0 due to the intended change made in  Issue 856665  . Hence assigning it to kozy@ owner of the mentioned issue for further inputs and removing Needs-Bisect label.
Note: CC'ing Alexey Kozyatinskiy, author of change made in 856665.
Adding RB-Stable for M-69, please remove if not required.
Cc: ligim...@chromium.org
vamshi.kommuri@ is this still reproducible?
Re to c#3, Yes it's reproducible i.e., not working as reporter's expected behaviour.

Our Observations:
-----------------

@ligimole: Checked the issue in latest canary 69.0.3497.0 using Mac 10.13.1, as per the reporter's answer to "What is the expected behaviour?" in comment#0 latest canary isn't working as expected i.e., in latest canary we are able to set BP at every line where as reporter needs it in other way(...as mentioned in C#0). As per   Issue 856665   which is mentioned in C#2 rather this seems to be an intended change.

Thanks!
kozy@, 
Friendly ping to get an update on this issue as it is marked as RBS.
Thanks..!
@kozy : Gentle ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Labels: -ReleaseBlock-Stable
It is intended behavior. We show inline breakpoint only for current line, if there is no breakable locations within current line we set breakpoint at next breakpoint location inside current function.
This one is definitely not release block stable.
Just to make sure, this issue refers to the inconsistent behaviour in breakpoint sliding between line 7 and line 10.

Also the breakpoint from line 7 is moved to line 10, where when manually placing a breakpoint at this location, it is moved to line 11 (inside the function).

For reference, I have attached a video of the same actions executed in current stable.
devtools_stable.mkv
87.8 KB Download
Cc: kozy@chromium.org
 Issue 863656  has been merged into this issue.
Mergedinto: 862978
Status: Duplicate (was: Assigned)

Sign in to add a comment