New issue
Advanced search Search tips

Issue 862959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 861808



Sign in to add a comment

object-src-inject.html is flaky

Project Member Reported by arthurso...@chromium.org, Jul 12

Issue description

The layout test: object-src-inject.html is flaky.

expected outout:
~~~


~~~

actual output when failing:

~~~
CONSOLE MESSAGE: Blink Test Plugin: initializing


~~~

At a first glance, it looks like the log message in:
https://cs.chromium.org/chromium/src/ppapi/tests/blink_test_plugin.cc?type=cs&q=%22Blink+Test+Plugin%22&sq=package:chromium&g=0&l=156

is racing with the end of the layout test.
 
Status: Started (was: Untriaged)
Blocking: 861808
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83b84428f235e8fb47c72acb621d1d382ee866f0

commit 83b84428f235e8fb47c72acb621d1d382ee866f0
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Mon Jul 30 08:08:36 2018

Fix flaky xssAuditor test.

The layout test: object-src-inject.html is flaky.
Sometimes, this line is printed:
```
   CONSOLE MESSAGE: Blink Test Plugin: initializing
```

It is fired from BlinkTestInstance::Init(...);

It is racing with the end of the layout test.
This CL disables console error dump to avoid this issue.

Bug:  862959 , 831155
Change-Id: I912e71b9ff8b7b5ccd7a4716f111f2017493e37a
Reviewed-on: https://chromium-review.googlesource.com/1135003
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578994}
[modify] https://crrev.com/83b84428f235e8fb47c72acb621d1d382ee866f0/third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/object-src-inject.html

Cc: -arthurso...@chromium.org
Owner: arthurso...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment