New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

browser_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 12

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mkwst@chromium.org

browser_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29

The following tests are failing consistently on all the Mac bots:

- ViewIDTest.Basic
- ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache
- ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache


 
Cc: mmenke@chromium.org
It looks like https://chromium-review.googlesource.com/c/chromium/src/+/1130162 may be responsible for ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache and ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache. Reverting. (+mmenke, FYI).
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8

commit eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8
Author: Mike West <mkwst@chromium.org>
Date: Thu Jul 12 09:35:30 2018

Revert "Delete the media cache(s) when using a single combined HTTP cache."

This reverts commit e226149af1b3f003b5d3f59e19ee17bef7419c42.

Reason for revert: 

`ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache` and `ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache` have been failing, apparently since they were added by this CL.

They were added here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28016 (which failed to actually run `browser_test`) and have been failing consistently since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018.


Original change's description:
> Delete the media cache(s) when using a single combined HTTP cache.
> 
> This is so that I can try increasing the media cache size in experiments
> without increasing Chrome's profile size (Except possibly for profiles
> that have never been used to play video).
> 
> Bug: 789657
> Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
> Reviewed-on: https://chromium-review.googlesource.com/1130162
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574296}

TBR=mmenke@chromium.org,morlovich@chromium.org

Change-Id: Ibc519750f00ad7e698d279af6baffe77b32d30be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789657,  862945 
Reviewed-on: https://chromium-review.googlesource.com/1134886
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574513}
[modify] https://crrev.com/eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8/chrome/browser/profiles/profile_impl_io_data.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fc8ad7e2561f48248fee640b72a808f1592634a

commit 8fc8ad7e2561f48248fee640b72a808f1592634a
Author: Mike West <mkwst@chromium.org>
Date: Thu Jul 12 09:52:33 2018

Disabling ViewIDTest.Basic.

This test is consistently failing on:

* 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018
* 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366
* 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145

TBR=mkwst@chromium.org,kpaulhamus@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  862945 
Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908
Reviewed-on: https://chromium-review.googlesource.com/1134780
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574518}
[modify] https://crrev.com/8fc8ad7e2561f48248fee640b72a808f1592634a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Hi Mike,

The crashes in Crashpad are clearly the same bug as crbug.com/862466 (and the right people are CC'd on that bug, although none of them have responded as of this point). As you determined, the other failures are different (and it looks like you have a handle on those).
Owner: ----
Components: -Internals>GPU>Testing Internals>Network>Cache Internals>Media
Status: Fixed (was: Available)

Sign in to add a comment