New issue
Advanced search Search tips

Issue 862931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 862929



Sign in to add a comment

Extend wasm fuzzers to test mixed Turbofan/Liftoff execution

Project Member Reported by clemensh@chromium.org, Jul 12

Issue description

We currently only test Liftoff and Turbofan in isolation. We should also test calling from one tier to another.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cbe423467c9478a6ac286799744dbe3bb384ccf9

commit cbe423467c9478a6ac286799744dbe3bb384ccf9
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Jul 12 12:56:30 2018

[wasm][fuzzer] Test combinations of Turbofan and Liftoff

Currently the fuzzer only tests Turbofan and Liftoff in isolation. In
order to test that both tiers use the same ABI, it should also test
calls from one tier to the other.
This CL introduces a new flag which controls which function will be
compiled by which tier, and uses that in the fuzzer.

R=ahaas@chromium.org

Bug:  chromium:862931 , v8:6600
Change-Id: I450b906700972cfdb496b1734faed9f8208d652f
Reviewed-on: https://chromium-review.googlesource.com/1134775
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54409}
[modify] https://crrev.com/cbe423467c9478a6ac286799744dbe3bb384ccf9/src/flag-definitions.h
[modify] https://crrev.com/cbe423467c9478a6ac286799744dbe3bb384ccf9/src/wasm/function-compiler.cc
[modify] https://crrev.com/cbe423467c9478a6ac286799744dbe3bb384ccf9/test/fuzzer/wasm-fuzzer-common.cc
[modify] https://crrev.com/cbe423467c9478a6ac286799744dbe3bb384ccf9/test/mjsunit/mjsunit.status
[add] https://crrev.com/cbe423467c9478a6ac286799744dbe3bb384ccf9/test/mjsunit/wasm/tier-up-testing-flag.js

Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 16

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 22

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment