This issue serves as a tracking bug for both measuring the occurrences and removal of duplicated blacklist entries in the password store.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ee73da3e8b0609545b89dda1f080e89d2d0ec8 commit 75ee73da3e8b0609545b89dda1f080e89d2d0ec8 Author: Gemene Narcis <gemene@google.com> Date: Mon Jul 16 08:57:59 2018 Add a metric for blacklisted password forms A metric is reported to find how many blacklisted forms exist in the password store. R=isherman@chromium.org, jdoerrie@chromium.org, vabr@chromium.org Bug: 862930 Change-Id: I11f89c78b4d6e9bc0755b1a0b53249f497d1729c Reviewed-on: https://chromium-review.googlesource.com/1131181 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575206} [modify] https://crrev.com/75ee73da3e8b0609545b89dda1f080e89d2d0ec8/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/75ee73da3e8b0609545b89dda1f080e89d2d0ec8/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/75ee73da3e8b0609545b89dda1f080e89d2d0ec8/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5df1bbaaf0055a7963dc16bfce6e2a7b34b8cf18 commit 5df1bbaaf0055a7963dc16bfce6e2a7b34b8cf18 Author: Gemene Narcis <gemene@google.com> Date: Wed Jul 25 10:41:20 2018 Add bubble behavior browser tests These tests are supposed to validate the behavior that bubble has when a user has blacklisted a site from a type of form and then login successfully from another type of form from the site. For tests were used HTML and HTTP auth forms. The bubble will not be shown if in the PasswordStore exists an blacklisted entry with the same signon_realm as submitted form. Even if the submited form has different Password::Scheme, if the signon_realm is the same as blacklisted one, then the bubble will not be shown. Bug: 456158, 862930 Change-Id: I7b07bb6164be315f43fe1609f4ac167233b76869 Reviewed-on: https://chromium-review.googlesource.com/1148560 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577837} [modify] https://crrev.com/5df1bbaaf0055a7963dc16bfce6e2a7b34b8cf18/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/5df1bbaaf0055a7963dc16bfce6e2a7b34b8cf18/chrome/browser/password_manager/password_manager_test_base.cc [modify] https://crrev.com/5df1bbaaf0055a7963dc16bfce6e2a7b34b8cf18/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a631a4a534d2bf18dd71ac819662fcf7a6c1958b commit a631a4a534d2bf18dd71ac819662fcf7a6c1958b Author: Gemene Narcis <gemene@google.com> Date: Thu Jul 26 15:59:42 2018 Remove blacklisted duplicates Blacklisted credentials are special PasswordForm instances saved in PasswordStore, which record the user's choice never to store credentials for a given site. When PasswordFormManager asks for all stored forms for a given PasswordStore::FormDigest(scheme, realm and origin), it suppresses all saving functions as long as there is at least one entry marked as blacklisted. In particular, saving more than one blacklisted entry for a given scheme/realm/origin combination has no additional effect compared to just one. Nevertheless, duplicates could have been created by older versions of Chrome, and their frequency is measured by the PasswordManager.BlacklistedDuplicates histogram. To avoid potentially confusing the user by copies of the blacklisted entries and also to avoid potential bugs when deleting just one blacklisted entry would keep the site blacklisted, this CL makes the PasswordStore prune duplicated blacklist entries on start-up. Bug: 862930 Change-Id: I48d8919139c50c267053244573b70b246e9e99b2 Reviewed-on: https://chromium-review.googlesource.com/1140158 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578318} [modify] https://crrev.com/a631a4a534d2bf18dd71ac819662fcf7a6c1958b/chrome/browser/password_manager/password_store_factory.cc [modify] https://crrev.com/a631a4a534d2bf18dd71ac819662fcf7a6c1958b/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/a631a4a534d2bf18dd71ac819662fcf7a6c1958b/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/a631a4a534d2bf18dd71ac819662fcf7a6c1958b/components/password_manager/core/browser/password_manager_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c6c7b842947b8aab18141088902fe85e1d9dc89 commit 9c6c7b842947b8aab18141088902fe85e1d9dc89 Author: Gemene Narcis <gemene@google.com> Date: Mon Aug 06 10:05:49 2018 Prevent adding blacklisted duplicates Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. Bug: 862930 Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc Reviewed-on: https://chromium-review.googlesource.com/1151636 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580836} [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/login_database.h [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/browser/password_manager_util_unittest.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/common/password_manager_pref_names.cc [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/components/password_manager/core/common/password_manager_pref_names.h [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9c6c7b842947b8aab18141088902fe85e1d9dc89/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1297aad18075b6ad022cc4a51c3b1da0047cb546 commit 1297aad18075b6ad022cc4a51c3b1da0047cb546 Author: Balazs Engedy <engedy@chromium.org> Date: Mon Aug 06 13:59:24 2018 Revert "Prevent adding blacklisted duplicates" This reverts commit 9c6c7b842947b8aab18141088902fe85e1d9dc89. Reason for revert: Breaks continuous builder `ios-simulator-full-configs` at step ios_chrome_settings_egtests, due to failing test case: PasswordsSettingsTestCase/testDuplicatedBlacklistedFormDeletionInDetailView See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs/8679 Original change's description: > Prevent adding blacklisted duplicates > > Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. > > Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. > > Bug: 862930 > Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc > Reviewed-on: https://chromium-review.googlesource.com/1151636 > Commit-Queue: Narcis Gemene <gemene@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580836} TBR=vabr@chromium.org,vasilii@chromium.org,bcwhite@chromium.org,jdoerrie@chromium.org,gemene@google.com Change-Id: I06c5272bf5ce355f40f58a3075bba9a5794d4ee6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862930 Reviewed-on: https://chromium-review.googlesource.com/1162023 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580859} [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/login_database.h [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/browser/password_manager_util_unittest.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/common/password_manager_pref_names.cc [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/components/password_manager/core/common/password_manager_pref_names.h [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1297aad18075b6ad022cc4a51c3b1da0047cb546/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea9b5ee08b766efcf2ea8188f2444b52db93696 commit 9ea9b5ee08b766efcf2ea8188f2444b52db93696 Author: Gemene Narcis <gemene@google.com> Date: Thu Aug 16 08:38:20 2018 Reland "Prevent adding blacklisted duplicates" This is a reland of 9c6c7b842947b8aab18141088902fe85e1d9dc89 Also, this CL deletes testDuplicatedBlacklistedFormDeletionInDetailView because duplicates are cleaned up in r578318 and this CL doesn't allow Password Store to add new ones. Thus, the test is obsolete. Original change's description: > Prevent adding blacklisted duplicates > > Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. > > Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. > > Bug: 862930 > Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc > Reviewed-on: https://chromium-review.googlesource.com/1151636 > Commit-Queue: Narcis Gemene <gemene@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580836} Bug: 862930 , 871223 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a66bf412b7b89ba5ad61a7d99faa26e5910ff9d Reviewed-on: https://chromium-review.googlesource.com/1164783 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#583583} [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database.h [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager_util_unittest.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/common/password_manager_pref_names.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/common/password_manager_pref_names.h [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a commit 4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a Author: Gemene Narcis <gemene@google.com> Date: Mon Sep 03 13:57:58 2018 Move BlacklistedDuplicatesCleaner into a separate class This CL move the class that removes blacklisted credentials that are duplicates in separate files and create stronger unittests for that class. Bug: 862930 Change-Id: Ia07004779bc66d01a3268f7fc4d2779beabb89a2 Reviewed-on: https://chromium-review.googlesource.com/1199385 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588385} [modify] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/BUILD.gn [add] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/blacklisted_duplicates_cleaner.cc [add] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/blacklisted_duplicates_cleaner.h [add] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/blacklisted_duplicates_cleaner_unittest.cc [modify] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/4c9b5c12ca6829e9c3864ffe14672c63dc7fa36a/components/password_manager/core/browser/password_manager_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95f627dc8949297d1419f1e1694bc58ce90bbeca commit 95f627dc8949297d1419f1e1694bc58ce90bbeca Author: Gemene Narcis <gemene@google.com> Date: Tue Sep 04 08:17:39 2018 Rename BlacklistedDuplicatesCleaner class This CL renames class with name BlacklistedDuplicatesCleaner to RedundantCredentialsCleaner. This is to reflect expanding this class to handle also non-blacklisted credentials, which will be done in coming CLs Bug: 862930 Change-Id: Ifba11a521775cbcd33c183aa685ae84a591d8457 Reviewed-on: https://chromium-review.googlesource.com/1202664 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588473} [modify] https://crrev.com/95f627dc8949297d1419f1e1694bc58ce90bbeca/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/95f627dc8949297d1419f1e1694bc58ce90bbeca/components/password_manager/core/browser/password_manager_util.cc [rename] https://crrev.com/95f627dc8949297d1419f1e1694bc58ce90bbeca/components/password_manager/core/browser/redundant_credentials_cleaner.cc [rename] https://crrev.com/95f627dc8949297d1419f1e1694bc58ce90bbeca/components/password_manager/core/browser/redundant_credentials_cleaner.h [rename] https://crrev.com/95f627dc8949297d1419f1e1694bc58ce90bbeca/components/password_manager/core/browser/redundant_credentials_cleaner_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb commit 5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb Author: Narcis Gemene <gemene@google.com> Date: Tue Sep 11 12:36:57 2018 Revert "Rename BlacklistedDuplicatesCleaner class" This reverts commit 95f627dc8949297d1419f1e1694bc58ce90bbeca. Reason for revert: The class will not be expanded anymore. Original change's description: > Rename BlacklistedDuplicatesCleaner class > > This CL renames class with name BlacklistedDuplicatesCleaner to > RedundantCredentialsCleaner. This is to reflect expanding this > class to handle also non-blacklisted credentials, which will be > done in coming CLs > > Bug: 862930 > Change-Id: Ifba11a521775cbcd33c183aa685ae84a591d8457 > Reviewed-on: https://chromium-review.googlesource.com/1202664 > Commit-Queue: Narcis Gemene <gemene@google.com> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588473} TBR=vabr@chromium.org,jdoerrie@chromium.org,gemene@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862930 Change-Id: I7edb0dfaeed734109d928694be48667228edd54d Reviewed-on: https://chromium-review.googlesource.com/1219606 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#590277} [modify] https://crrev.com/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb/components/password_manager/core/browser/BUILD.gn [rename] https://crrev.com/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb/components/password_manager/core/browser/blacklisted_duplicates_cleaner.cc [rename] https://crrev.com/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb/components/password_manager/core/browser/blacklisted_duplicates_cleaner.h [rename] https://crrev.com/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb/components/password_manager/core/browser/blacklisted_duplicates_cleaner_unittest.cc [modify] https://crrev.com/5dc19a54eb63f92cea9e6673f3fcfd201e2d08fb/components/password_manager/core/browser/password_manager_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b074c3fee15ea87b936128fc3c53e584b70a7b65 commit b074c3fee15ea87b936128fc3c53e584b70a7b65 Author: Gemene Narcis <gemene@google.com> Date: Fri Sep 14 16:07:16 2018 [Password Manager] Add a class that runs start-up clean-ups This CL adds a new class that executes credential clean-ups in the order they are added. This is needed to easily manipulate the clean-ups which will be added in coming CLs. Bug: 862930 Change-Id: Ie21ec931ea2d21b3d0f3d3ff4475f69ae58aa10b Reviewed-on: https://chromium-review.googlesource.com/1220149 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591359} [modify] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/blacklisted_duplicates_cleaner.cc [modify] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/blacklisted_duplicates_cleaner.h [add] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/credentials_cleaner.h [add] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/credentials_cleaner_runner.cc [add] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/credentials_cleaner_runner.h [add] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/credentials_cleaner_runner_unittest.cc [modify] https://crrev.com/b074c3fee15ea87b936128fc3c53e584b70a7b65/components/password_manager/core/browser/password_manager_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f202d28ea3528554772c2215a1420e4317ed664f commit f202d28ea3528554772c2215a1420e4317ed664f Author: Gemene Narcis <gemene@google.com> Date: Mon Sep 17 17:46:42 2018 Minor clean-ups in BlacklistedDuplicatesCleaner This CL introduces a very small change in the name of unittest class that checks the functionality of class that removes blacklisted duplicates. Also, two comments and the missing #include from header file of BlacklistedDuplicatesCleaner are added. Bug: 862930 Change-Id: I0bc08a9e78b70f762aa6182daa82ce808632080f Reviewed-on: https://chromium-review.googlesource.com/1225982 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591731} [modify] https://crrev.com/f202d28ea3528554772c2215a1420e4317ed664f/components/password_manager/core/browser/blacklisted_duplicates_cleaner.h [modify] https://crrev.com/f202d28ea3528554772c2215a1420e4317ed664f/components/password_manager/core/browser/blacklisted_duplicates_cleaner_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/159ea0fa1f7ca164dac9e74c34331afbc56b79d3 commit 159ea0fa1f7ca164dac9e74c34331afbc56b79d3 Author: Gemene Narcis <gemene@google.com> Date: Thu Sep 20 13:42:25 2018 Support cleaning blacklisted duplicates for iOS platform This CL allows cleaning of blacklisted duplicates for iOS platform. Bug: 862930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I44e9fb90181781c261760ac0d933f8917b7d2910 Reviewed-on: https://chromium-review.googlesource.com/1233234 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#592779} [modify] https://crrev.com/159ea0fa1f7ca164dac9e74c34331afbc56b79d3/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
Comment 1 by bugdroid1@chromium.org
, Jul 16