New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862926 link

Starred by 2 users
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Nov 22
Cc:
ajha@chromium.org
█ sashab@chromium.org
weifangsun@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression: Unnecessary blink of 'Open with Gallery' 'Open with' , 'More actions' and 'New Folder' options are seen in Menu after selecting 'Get info' option in FilesApp

Project Member Reported by mmanchala@chromium.org, Jul 12 
Chrome Version: 68.0.3440.59/10718.50.0 - Kip,Reks & Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download image -> go to Files App-> select image so that 'Cancel selection','Open','Delete' and 'Three dot menu' options are seen
(3)Now Click on 'Three dot menu' and select 'Get info' option in Menu -> observe blink of 'Open with Gallery' 'Open with' , 'More actions' and 'New Folder' options are seen in Menu
(Please refer Video and Screenshot)

Expected: No such blink of 'Open with Gallery' 'Open with' , 'More actions' and 'New Folder' options should be seen in Menu
Actual: Instead unnecessary blink of 'Open with Gallery' 'Open with' , 'More actions' and 'New Folder' options are seen in Menu

This is Non-Regression Issue seen from M-62
Actual_UnnecessaryOptions.mp4
14.6 MB View Download
Actual_UnnecessaryOptions.jpg
101 KB View Download
Expected_Menu.jpg
101 KB View Download

Comment 1 by weifangsun@chromium.org, Jul 18

Cc: sashab@chromium.org
Labels: -Pri-2 -M-68 CrOSFilesCategory-UI Pri-3
Status: Available (was: Untriaged)

Comment 2 by weifangsun@chromium.org, Nov 7

Labels: Files-Fixit-2018

Comment 3 by joelhockey@chromium.org, Nov 21

Owner: joelhockey@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f8df510f416d59c4dc2a5d7f849943956bfff4

commit c5f8df510f416d59c4dc2a5d7f849943956bfff4
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Nov 22 07:00:55 2018

FilesApp selection menu delay remove toolbar-menu class to avoid flicker

Remove the 'toolbar-menu' class when menu closing animation is
complete to avoid flicker.

Bug:  862926 
Change-Id: I8b52b86297a5f629d00b8cf43bce3c537a6ef323
Reviewed-on: https://chromium-review.googlesource.com/c/1347957
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610324}
[modify] https://crrev.com/c5f8df510f416d59c4dc2a5d7f849943956bfff4/ui/file_manager/file_manager/foreground/js/selection_menu_controller.js
[modify] https://crrev.com/c5f8df510f416d59c4dc2a5d7f849943956bfff4/ui/file_manager/file_manager/foreground/js/ui/files_menu.js

Comment 5 by joelhockey@chromium.org, Nov 22

Status: Fixed (was: Started)
►

Sign in to add a comment