New issue
Advanced search Search tips

Issue 862925 link

Starred by 2 users
Status: Verified
Owner:
pbos@chromium.org
Closed: Jul 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring is not seen properly on 'Error' icon of passphrase.

Reported by db...@etouch.net, Jul 12 
Chrome Version: 69.0.3489.0 Revision 66d7b6411564744a0d3589943331a0a7db096a3d-refs/branch-heads/3489@{#1}(64 bit)
OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14) 

Pre-condition: Sign in into browser with valid credentials which has Passphrase.

What steps will reproduce the problem?
(1) Launch chrome, open NTP and press tab key upto focus reaches to Error icon.
(2) Observe focus on Error icon.

Actual: Focus ring is not seen properly on Error icon of passphrase.

Expected: Focus ring should seen properly on Error icon of passphrase.

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3487.0  (Revision: 573575).
Bad build: 69.0.3488.0 (Revision: 574034).

Note: Issue is not seen on Windows (7,8,8.1,10) and Linux (14.04 LTS) OS.
Focus_Actual.mov
3.6 MB View Download
Focus_Expected.mov
1.9 MB View Download

Comment 1 by db...@etouch.net, Jul 12

Labels: RegressedIn-69 Target-69 FoundIn-69
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 573751 (known good), but no later than 573752 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/8f21903ed1fd103550952df63a74ddf1f2b89e56..67dfce1fde18a82e97527ad3c755b2e9ea720d07

Suspect: https://chromium.googlesource.com/chromium/src/+/67dfce1fde18a82e97527ad3c755b2e9ea720d07

@pbos: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by dpa...@chromium.org, Jul 12

Components: -UI>Settings UI>Browser>Omnibox UI>Browser
Not sure if Omnibox is the right component for this, but it definitely seems more related to omnibox than it is with Settings. Feel free to re-assign to a more appropriate component if one exists.

Comment 3 by robliao@chromium.org, Jul 12

Labels: Proj-MdRefresh

Comment 4 by robliao@chromium.org, Jul 12

Labels: Group-Avatar_Button

Comment 5 by jdonnelly@chromium.org, Jul 13

Components: -UI>Browser>Omnibox UI>Browser>Toolbar
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38410b62b95dae578cc342954f91f227de4315f3

commit 38410b62b95dae578cc342954f91f227de4315f3
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jul 17 15:47:11 2018

Use FocusRing RoundRects to match toolbar inkdrops

Creates a SkPath that matches the inkdrop shape and use that as the
focus ring.

In the future, hopefully the inkdrop shape can be generated from the
same path so that they are forced to stay in sync. For now though they
are less separate as the focus ring shape is generated using the same
insets as the inkdrop.

This focus ring is installed for ToolbarButton, BrowserAppMenuButton and
ToolbarActionView (all are visibly toolbar buttons).

Bug:  chromium:862925 
Change-Id: I898d2d9c6a9e058e9f84aff37615ebf3ab41cee7
Reviewed-on: https://chromium-review.googlesource.com/1139221
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575653}
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/browser_app_menu_button.h
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/38410b62b95dae578cc342954f91f227de4315f3/chrome/browser/ui/views/toolbar/toolbar_view.cc

Comment 7 by pbos@chromium.org, Jul 18

Status: Fixed (was: Assigned)

Comment 8 by db...@etouch.net, Jul 18

Labels: TE-Verified-M69 TE-Verified-69.0.3495.0
Update :

Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.6) OS with latest Canary Chrome version: 69.0.3495.0 and the issue is Fixed.Hence adding TE Verified Labels.Kindly refer the attached screen cast for reference.

Thank you.
Fix_Issue.mov
2.1 MB View Download

Comment 9 by pbos@chromium.org, Jul 18

Status: Verified (was: Fixed)
Thank you!
►

Sign in to add a comment