New issue
Advanced search Search tips

Issue 862924 link

Starred by 3 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Nov 13
Cc:
ajha@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Digit is not deleted on clicking 'Enter' when tab focus is on 'Backspace' option in 'Enter your PIN' overlay of chrome://settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Jul 12 
Chrome Version: 68.0.3440.59/10718.50.0 - Kip,Reks & Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
(2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN'
(3)In 'Enter your PIN' overlay -> enter 3-4 digits and observe 'Backspace' option is enabled ->Press 'Tab' key until focus is on 'Backspace' option
(4)Now click on 'Enter' from keyboard and observe focus moves to 'PIN' field and no focus is seen on 'Backspace' option -> observe digit is also not erased
(Please refer Video)

Expected: Digit should get erased on clicking 'Enter' when tab focus is on 'Backspace' option
Actual: Instead focus moves to 'PIN' field and no focus is seen on 'Backspace' option

This is Non-Regression Issue seen from M-67

Note: In M-62 to M-66 on clicking 'Enter' nothing happens but tab focus remains on 'Backspace' option

@sammiequon : Please confirm the Issue
Actual_DeleteKey.mp4
19.2 MB Download
Expected_KeyBehavior.mp4
11.6 MB View Download

Comment 1 by mmanchala@chromium.org, Jul 16

Expected_BackSpaceBehavior.mp4
13.4 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ef725be055cbf7d9e47b33211d66bbec884297

commit a0ef725be055cbf7d9e47b33211d66bbec884297
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Nov 13 22:29:08 2018

cros: Show correct PIN setup error message after highlight and delete.

Also fix issue where users could not backspace by using keyboard tab
and space.

Test: manual
Bug:  881756 ,  862924 
Change-Id: I0523784ad05d2a02219e95e90cd02b2d275da94f
Reviewed-on: https://chromium-review.googlesource.com/c/1329748
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607768}
[modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[modify] https://crrev.com/a0ef725be055cbf7d9e47b33211d66bbec884297/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js

Comment 3 by sammiequon@chromium.org, Nov 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment