New issue
Advanced search Search tips

Issue 862917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

compare_build_artifacts step fails to compare object files difference

Project Member Reported by yyanagisawa@chromium.org, Jul 12

Issue description

In recent bots, ninja seems not be included in PATH, and code to
get deps using ninja fails.

 
e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20Clang%20deterministic/10765
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941241698179675504%2F%2B%2Fsteps%2Fcompare_build_artifacts%2F0%2Fstdout
Traceback (most recent call last):
  File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\determinism\compare_build_artifacts.py", line 351, in <module>
    sys.exit(main())
  File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\determinism\compare_build_artifacts.py", line 347, in main
    options.recursive)
  File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\determinism\compare_build_artifacts.py", line 303, in compare_build_artifacts
    deps_diff = compare_deps(first_dir, second_dir, diffs_to_investigate)
  File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\determinism\compare_build_artifacts.py", line 214, in compare_deps
    first_deps = get_deps(first_dir, target)
  File "C:\b\swarming\w\ir\kitchen-workdir\src\tools\determinism\compare_build_artifacts.py", line 185, in get_deps
    '-t', 'graph', target])
  File "C:\b\swarming\w\ir\cipd_bin_packages\bin\Lib\subprocess.py", line 212, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "C:\b\swarming\w\ir\cipd_bin_packages\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\b\swarming\w\ir\cipd_bin_packages\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
step returned non-zero exit code: 1
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f55b21a7a48593a9ce1622346dad112a8b2e2f

commit c3f55b21a7a48593a9ce1622346dad112a8b2e2f
Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Date: Thu Jul 12 12:49:34 2018

compare_build_artifacts: make ninja path command line option.

ninja seems not be in PATH when compare_build_artifacts.py is executed.
Then compare_build_artifacts cannot compare object files difference,
and just fails with exception.
To fix that, let me make ninja path given with command line option.

Bug:  862917 
Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
Reviewed-on: https://chromium-review.googlesource.com/1134710
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574540}
[modify] https://crrev.com/c3f55b21a7a48593a9ce1622346dad112a8b2e2f/tools/determinism/compare_build_artifacts.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/615448ae4278aae0da12b91f8b03cc9efe666b3e

commit 615448ae4278aae0da12b91f8b03cc9efe666b3e
Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Date: Fri Jul 13 12:21:22 2018

Explicitly specify ninja path in deterministic builder.

Some builders that do not have ninja in its PATH fail to get
dependencies in compare_build_artifacts.py because it cannot execute
ninja.
This cl explicitly specify ninja path to fix the issue.

Bug:  862917 
Change-Id: I7f304e9c9c97e0be56079ce38d4be329aed148a0
Reviewed-on: https://chromium-review.googlesource.com/1135882
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg_.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux__dbg_.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android__dbg__fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipe_modules/isolate/__init__.py
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipe_modules/isolate/tests/compare_build_artifacts.expected/basic.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android__dbg_.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux__dbg__fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_fail.json
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/README.recipes.md
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipe_modules/isolate/api.py
[modify] https://crrev.com/615448ae4278aae0da12b91f8b03cc9efe666b3e/scripts/slave/recipe_modules/isolate/tests/compare_build_artifacts.expected/failure.json

Owner: yyanagisawa@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment