New issue
Advanced search Search tips

Issue 862916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted movement of 'Outer row' is seen on clicking 'Use Hardware acceleration' in chrome://settings/system.

Reported by rp...@etouch.net, Jul 12

Issue description

Version: 69.0.3489.0 (Official Build)Revision 66d7b6411564744a0d3589943331a0a7db096a3d-refs/branch-heads/3489@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/system
2. Now click on 'Use Hardware acceleration when available' and observe
 
Actual: Unwanted movement of 'Outer row' is seen after clicking on 'Use Hardware acceleration when available'
Expected: Unwanted movement of 'Outer row' shouldn't be seen

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3488.0  (Revision: 574035).
Bad build: 69.0.3489.0 (Revision: 574445).
 
Actual_video.mp4
232 KB View Download
Expected_video.mp4
150 KB View Download
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: proberge@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 574422 (known good), but no later than 574423 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/803005b59bef10b2d804a5827d626dcc9d10d906..1b307437f07306488f4a72f45bec3e1217f0a99b

Suspect : https://chromium.googlesource.com/chromium/src/+/1b307437f07306488f4a72f45bec3e1217f0a99b

From the CL above, assigning the issue to the concern owner 

@proberge- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!
Cc: namratakannan@chromium.org dpa...@chromium.org
Thanks for the bug report. This is indeed related to https://chromium.googlesource.com/chromium/src/+/1b307437f07306488f4a72f45bec3e1217f0a99b. 

@dpapad looks like my change is causing trouble with this use case (clicking on the row creates a button whose height is greater than the text's height, causing the entire row to expand vertically). 

There's two settings-toggle-button which can contain "Relaunch" buttons:
1. "Use hardware acceleration" in chrome://settings/system
2. Metrics reporting in chrome://settings/privacy

The only way I can think of fixing the issue is by setting a -4px margin-top and margin-bottom on paper-buttons inside of settings-toggle-buttons. I'm not a fan of negative margins so this seems wrong; wdyt?
Found a different fix and sent https://chromium-review.googlesource.com/c/chromium/src/+/1135594 for review.
Thanks, I'll take a look shortly.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cc132179eeffbd20de9cc4ba2db08e682cde7b0

commit 9cc132179eeffbd20de9cc4ba2db08e682cde7b0
Author: proberge <proberge@chromium.org>
Date: Fri Jul 13 17:33:09 2018

Chrome settings: adjust CSS to fix relayout of settings_toggle_button

In https://chromium-review.googlesource.com/c/chromium/src/+/1133300 I
changed how the padding of settings_toggle_button is calculated. This
caused some issues in cases where clicking the row creates a button
whose height is greater than the text's height, causing the entire row
to expand vertically.

This change applies the padding modifications to the text label instead
of the entire outerRow, preventing the padding from applying based on
the button's height instead of the text height.

Bug:  862916 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I489f8e38d022452e448ab452def29ca02aa0a1cb
Reviewed-on: https://chromium-review.googlesource.com/1135594
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574962}
[modify] https://crrev.com/9cc132179eeffbd20de9cc4ba2db08e682cde7b0/chrome/browser/resources/settings/controls/settings_toggle_button.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Update :
Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS with latest Canary Chrome version : 69.0.3493.0 and the issue is Fixed.Kindly refer the attached screen cast for reference.
Fixed_video.mp4
252 KB View Download

Sign in to add a comment