Issue metadata
Sign in to add a comment
|
Regression : Unwanted green border is observed on Google logo (Second 'o') |
||||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3440.59 OS: Ubuntu 14.04 and 17.10 What steps will reproduce the problem? (1)Launch chrome and navigate to Google.com Expected result : There should not be any green border for 'o' in Google logo. Actual Result : Unwanted green border is observed. Note: Issue is not observed on Windows and Mac OS. Bisect information: =================== Good build :68.0.3402.0 Bad build : 68.0.3403.0 By running the per-revision bisect script, the below changelog URL was returned: https://chromium.googlesource.com/chromium/src/+log/854837b66271a2dd6078cd9595e6afc7bb2d0dec..a3796c2471b11c81c8b532d66388c1b5ea708c07 From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/1014327 brianosman@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding ReleaseBlock-Stable for M-68 as this is a recent regression. Please feel free to remove if it is not applicable. Thanks !
,
Jul 12
Can you check to see if you have a color profile installed for your monitor? There are instructions on locating the file under the section 'For Linux Users' in this document: https://docs.google.com/document/d/1jMokB_OBkZVELu22li8vnHxAUoL1eGnLedP-1Gttv40/view#heading=h.2to15xum98j3 If so, can you try disabling it (and also attaching a copy of the profile to this bug)? That will let us know if it's a malformed profile, or a bug in our usage of the profile.
,
Jul 12
,
Jul 12
The microphone and one of the little Chrome logos also show some green where we'd expect yellow.
,
Jul 16
Are there any updates on this bug yet? This is marked as RB-Stable for M68. brianosman@ - were you able to get all details that are needed to recreate this?
,
Jul 16
No updates - I won't be able to recreate this without the monitor color profile from the original submitter's machine.
,
Jul 17
swarnasree.mukkala@: Please update the bug with requested info as per C#2.
,
Jul 17
As per comment#2 followed the steps in both ways after executing the commands could not repro the issue on #68.0.3403.0 on Ubuntu 17.10 and 14.04.Please follow below for the observations.
Observations (Ubuntu 17.10):
-----------------------------
1.Could not repro issue as per comment#0, as there is doodle getting displayed today.So tried to repro issue by comment#4.
2.When followed the method-1 in the document, observed that under settings-->Devices-->Colors there is an option to on and off for the current profile.
1. when it is on the issue is getting repro
2. when off the issue is not getting repro
3.As per comment#6 tried to give the monitor color profile but the view details button is not enabled
4.document at step 2 in method 1 , removed the profiles then could not see view details button after that.Attaching screenshots for references.
Observations (Ubuntu 14.04):
-----------------------------
Able to repro the issue as per comment#4, when tried to follow the steps in the given document.
1. when tried to remove the profiles as per method-1 observed that remove profiles button is disabled
2. when tried to run the command at step2 in method 2 -colormgr get-devices, observed multiple objects paths are displayed
Request you to please check and confirm if anything is missed from our end in triaging the issue.
Thanks.!
,
Jul 17
Thank you for the additional information. You may be able to find the color profile in one of the following locations: /usr/share/color/icc/ /usr/local/share/color/icc ~/.local/share/icc/ One of those directories is likely to contain several files with a .icc extension. One of them will have a name similar to the profile's name "HP LV1911" (they are not named exactly the same). If you can find such a file, that would be great. Regardless, with the profile enabled (so the bug repros), can you navigate to chrome://gpu, and copy/paste the section under 'Display(s) Information'. That has some of the color profile information, and may be helpful.
,
Jul 18
Unable to repro the issue on Ubuntu 17.10 after executing the commands in method 2 given in the document at comment#2. On Ubuntu 17.10-When tried to get color profile by the paths given at comment #9, could find only one .icc file following the path ~/.local/share/icc/. Attached .icc file for reference. On Ubuntu 14.04-When tried to get color profile by the paths given at comment #9, could not find related to that. Attaching the Display(s) Information from chrome://gpu and screenshots for reference. Request you to please check and confirm if anything is missed from our end in triaging the issue. Thanks. !
,
Jul 19
This is specific to 'Linux' only and not a consistent repro across all linux machines. Hence removing the blocker label.
,
Jul 27
The following revision refers to this bug: https://skia.googlesource.com/skcms/+/23e7777f421d11992e8245771641141aa273556b commit 23e7777f421d11992e8245771641141aa273556b Author: Mike Klein <mtklein@google.com> Date: Fri Jul 27 14:42:26 2018 clamp before premul When alpha is <1, it's possible to fit r,g,b >1 into premul unorms, and that subverts the expectations users who consume the output of skcms_Transform(). When working with unorm pixels, downstream consumers will assume the r,g,b values are also within [0,1], i.e. are less than the alpha channel. Put another way, they assume the colors are in gamut. So clamp earlier, before premul. (The reordering has no effect on force_opaque or swap_rb.) Bug: chromium:867813 Bug: chromium:862908 Change-Id: I553b42df06482a4e3cd3a9377c2adddb8ff3d1bc Reviewed-on: https://skia-review.googlesource.com/143710 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> [modify] https://crrev.com/23e7777f421d11992e8245771641141aa273556b/skcms.cc
,
Jul 30
The following revision refers to this bug: https://skia.googlesource.com/skcms/+/6b7ef53d3298a7ab7e3410ba3ffe5623539f025e commit 6b7ef53d3298a7ab7e3410ba3ffe5623539f025e Author: Mike Klein <mtklein@google.com> Date: Mon Jul 30 13:04:23 2018 add unit test for clamp-before-premul Bug: chromium:867813 Bug: chromium:862908 Change-Id: I79a82b6637c8a707844642b9bce4444bb85828b5 Reviewed-on: https://skia-review.googlesource.com/144295 Auto-Submit: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> [modify] https://crrev.com/6b7ef53d3298a7ab7e3410ba3ffe5623539f025e/skcms.cc [modify] https://crrev.com/6b7ef53d3298a7ab7e3410ba3ffe5623539f025e/tests.c
,
Jul 31
,
Aug 10
,
Aug 17
This seems to work now (for me) in chromium Version 68.0.3440.106 on Ubuntu 18.04 (wayland) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by swarnasree.mukkala@chromium.org
, Jul 12