Issue 862897 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	lucmult@chromium.org
Closed:	Jul 13
Cc:	joelhockey@chromium.org
Components:	Platform>Apps>FileManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
CrOSFilesCategory-Testing CrOSFilesCategory-UI

Fix FileManagerUITest interference between tests

Project Member Reported by lucmult@chromium.org, Jul 12

Issue description

In crrev.com/c/1131025 the test "FileManagerUITest.Crostini >> testCrostiniSuccess" failed.

However when running this test in isolation it doesn't fail.

It only fails when it runs after the test testCrostiniError, according to my initial debugging.

It's failing during setupAndWaitUntilReady(), where Downloads folder isn't displaying its files on file list.

See failure logs below:
[ RUN      ] FileManagerUITest.Crostini
[21305:21305:0711/213730.888001:WARNING:chrome_browser_main_chromeos.cc(582)] Running as stub user with profile dir: test-user
[21305:21320:0711/213730.959243:ERROR:logging_chrome.cc(218)] Unable to create symlink /b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/dow5yT8/test-user/chrome_debug.log pointing at /b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/dow5yT8/test-user/chrome_debug_20180711-213730: No such file or directory (2)
[21305:21305:0711/213731.013907:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[21305:21305:0711/213731.013964:WARNING:remote_commands_service.cc(40)] Client is not registered.
[21305:21305:0711/213731.013995:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[21305:21305:0711/213731.014028:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[21305:21305:0711/213731.014056:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[21305:21305:0711/213731.014100:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[21305:21305:0711/213731.135612:ERROR:content_gpu_interface_provider.cc(86)] Not implemented reached in virtual void ash::ContentGpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[21305:21305:0711/213731.527193:INFO:CONSOLE(506)] "KeyboardEvent.Key polyfill not required", source: file:///b/s/w/ir/ui/webui/resources/js/util.js (506)
[21305:21305:0711/213731.766520:INFO:CONSOLE(130)] "Requesting volume list.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (130)
[21305:21305:0711/213731.783291:INFO:CONSOLE(132)] "Volume list fetched with: 2 items.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (132)
[21305:21305:0711/213731.783543:INFO:CONSOLE(142)] "Initializing volume: drive", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (142)
[21305:21305:0711/213731.783792:INFO:CONSOLE(95)] "Requesting file system.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (95)
[21305:21305:0711/213731.784321:INFO:CONSOLE(142)] "Initializing volume: downloads", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (142)
[21305:21305:0711/213731.784535:INFO:CONSOLE(95)] "Requesting file system.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (95)
[21305:21305:0711/213731.784959:INFO:CONSOLE(215)] "TEST testErrorOpeningDownloadsWithCrostiniApp starting...", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (215)
[21305:21305:0711/213731.800724:INFO:CONSOLE(143)] "File system obtained: drive", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (143)
[21305:21305:0711/213731.801890:INFO:CONSOLE(146)] "Initialized volume: drive", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (146)
[21305:21305:0711/213731.802268:INFO:CONSOLE(143)] "File system obtained: downloads", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (143)
[21305:21305:0711/213731.802536:INFO:CONSOLE(146)] "Initialized volume: downloads", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (146)
[21305:21305:0711/213731.802746:INFO:CONSOLE(150)] "Initialized all volumes.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (150)
[21305:21305:0711/213731.895339:INFO:CONSOLE(282)] "***************", source: file:///b/s/w/ir/ui/file_manager/file_manager/foreground/js/navigation_list_model.js (282)
[21305:21305:0711/213731.895629:INFO:CONSOLE(283)] "New nav: true", source: file:///b/s/w/ir/ui/file_manager/file_manager/foreground/js/navigation_list_model.js (283)
[21305:21305:0711/213731.895853:INFO:CONSOLE(284)] "***************", source: file:///b/s/w/ir/ui/file_manager/file_manager/foreground/js/navigation_list_model.js (284)
[21305:21316:0711/213732.228429:WARNING:extension_protocols.cc(472)] Failed to get directory for extension hhaomjibdihmijegdhdafkllkbggdgoj
[21305:21316:0711/213732.228462:WARNING:url_request_job_manager.cc(90)] Failed to map: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/metadata/metadata_dispatcher.js
[21305:21305:0711/213733.123022:INFO:CONSOLE(200)] "TEST testErrorOpeningDownloadsWithCrostiniApp complete, status=PASS, duration=1339ms", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (200)
[21305:21305:0711/213733.123252:INFO:CONSOLE(215)] "TEST testCrostiniMountOnDrag starting...", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (215)
[21305:21305:0711/213733.204770:INFO:CONSOLE(95)] "Requesting file system.", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (95)
[21305:21305:0711/213733.212220:INFO:CONSOLE(143)] "File system obtained: crostini", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_util.js (143)
[21305:21305:0711/213733.311058:INFO:CONSOLE(213)] "Mounted volume without a request: crostini", source: file:///b/s/w/ir/ui/file_manager/file_manager/background/js/volume_manager_impl.js (213)
[21305:21305:0711/213733.319674:INFO:CONSOLE(200)] "TEST testCrostiniMountOnDrag complete, status=PASS, duration=197ms", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (200)
[21305:21305:0711/213733.319928:INFO:CONSOLE(215)] "TEST testCrostiniError starting...", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (215)
[21305:21305:0711/213733.413085:INFO:CONSOLE(30)] "mountCrostiniContainer error: ", source: file:///b/s/w/ir/ui/file_manager/file_manager/common/js/error_util.js (30)
[21305:21305:0711/213733.469904:INFO:CONSOLE(200)] "TEST testCrostiniError complete, status=PASS, duration=150ms", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (200)
[21305:21305:0711/213733.470135:INFO:CONSOLE(215)] "TEST testCrostiniSuccess starting...", source: file:///b/s/w/ir/ui/webui/resources/js/webui_resource_test.js (215)
[21305:21305:0711/213736.505980:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213736.506218:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213739.521905:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213739.522145:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213742.485237:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213742.585593:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213745.499369:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213745.599596:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213748.510652:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213748.610998:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213751.522188:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213751.622483:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213754.533559:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213754.633853:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213757.546270:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213757.646493:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
[21305:21305:0711/213800.557540:INFO:CONSOLE(351)] "waitForFiles: expected: [["Beautiful Song.ogg","14 KB","OGG audio","Nov 12, 2086, 12:00 PM"],["My Desktop Background.png","272 bytes","PNG image","Jan 18, 2038, 1:02 AM"],["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"],["photos","--","Folder","Jan 1, 1980, 11:59 PM"],["world.ogv","59 KB","OGG video","Jul 4, 2012, 10:35 AM"]] actual [].", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (351)
[21305:21305:0711/213800.657910:INFO:CONSOLE(463)] "waitForFiles", source: file:///b/s/w/ir/ui/file_manager/file_manager/test/js/test_util.js (463)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000004acb27c base::debug::StackTrace::StackTrace()
#1 0x00000509d3f5 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f380d498cb0 <unknown>
#3 0x7f380d5606d3 epoll_wait
#4 0x000005789f3d epoll_dispatch
#5 0x000005787a1c event_base_loop
#6 0x000004ae7251 base::MessagePumpLibevent::Run()
#7 0x000004a3b554 base::MessageLoop::Run()
#8 0x000004a61fe9 base::RunLoop::Run()
#9 0x0000050a1d04 content::DOMMessageQueue::WaitForMessage()
#10 0x00000156e03b file_manager::FileManagerUITest::RunTest()
#11 0x00000156e406 file_manager::FileManagerUITest_Crostini_Test::RunTestOnMainThread()
#12 0x00000509c9d1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#13 0x000004ba807d ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#14 0x000004ba6e5a ChromeBrowserMainParts::PreMainMessageLoopRun()
#15 0x000001bbbe8a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#16 0x000002d78561 content::BrowserMainLoop::PreMainMessageLoopRun()
#17 0x0000031f4df5 content::StartupTaskRunner::RunAllTasksNow()
#18 0x000002d76e58 content::BrowserMainLoop::CreateStartupTasks()
#19 0x000002d7abe3 content::BrowserMainRunnerImpl::Initialize()
#20 0x000002d74a12 content::BrowserMain()
#21 0x000004991880 content::ContentMainRunnerImpl::Run()
#22 0x000006a8c845 service_manager::Main()
#23 0x00000498fb84 content::ContentMain()
#24 0x00000509c56c content::BrowserTestBase::SetUp()
#25 0x000004b48b2f InProcessBrowserTest::SetUp()
#26 0x00000205d47d testing::Test::Run()
#27 0x00000205e0a0 testing::TestInfo::Run()
#28 0x00000205e5b7 testing::TestCase::Run()
#29 0x000002069ab7 testing::internal::UnitTestImpl::RunAllTests()
#30 0x00000206962d testing::UnitTest::Run()
#31 0x000004b5ff21 base::TestSuite::Run()
#32 0x000004a16025 ChromeTestSuiteRunner::RunTestSuite()
#33 0x0000050bf05c content::LaunchTests()
#34 0x000004a164e3 LaunchChromeTests()
#35 0x000004a15fbe main
#36 0x7f380d483f45 __libc_start_main
#37 0x0000005fab7a _start
[1144/1144] FileManagerUITest.Crostini (TIMED OUT)
Retrying 1 test (retry #2)
Still waiting for the following processes to finish:
	./browser_tests --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=FileManagerUITest.Crostini --single_process --test-launcher-bot-mode --test-launcher-output=/b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/resultsGnVl07/test_results.xml --test-launcher-summary-output=/b/s/w/ioRXfL9l/output.json --user-data-dir=/b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/d0ymYQ2
Still waiting for the following processes to finish:
	./browser_tests --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=FileManagerUITest.Crostini --single_process --test-launcher-bot-mode --test-launcher-output=/b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/resultsGnVl07/test_results.xml --test-launcher-summary-output=/b/s/w/ioRXfL9l/output.json --user-data-dir=/b/s/w/it35OI60/.org.chromium.Chromium.7EPYQm/d0ymYQ2
[0711/213831.301132:ERROR:kill_posix.cc(83)] Unable to terminate process group 21387: No such process (3)
[ RUN      ] FileManagerUITest.Crostini

Comment 1 by lucmult@chromium.org, Jul 12

I'll disable the test for now to unblock my CL, because:

1. There is an integration test that tests the crostini mount success condition and it's passing.

2. The failing test actually succeeds when running on isolation.

This bug is to track a proper fix and re-enable this test.

Comment 2 by lucmult@chromium.org, Jul 12

Hum... when I disabled testCrostiniSuccess other tests failed on similar way, so before disabling all tests I'll check if I can fix it.

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e797cbfd3a992c22b021da9089d8f6b475e67710

commit e797cbfd3a992c22b021da9089d8f6b475e67710
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Jul 13 08:48:36 2018

Fix crostini tests

Changed util.isDescendantEntry to proper check if the children entry is
the same entry and addition to checking volumeEntry. This fixes the
issue where DirectoryTree wasn't immediately marking crostini FakeItem
as selected.

Changed NavigationListModel to remove crostini FakeEntry from My Files
if crostini becomes disabled, this fixes testCrostiniNotEnabled.

Removed containEntry method since it isn't needed anymore.

Bug:  862897 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia499266637c3d4c30677ac91ce30b6bd46b0ad99
Reviewed-on: https://chromium-review.googlesource.com/1136260
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574864}
[modify] https://crrev.com/e797cbfd3a992c22b021da9089d8f6b475e67710/ui/file_manager/file_manager/common/js/files_app_entry_types.js
[modify] https://crrev.com/e797cbfd3a992c22b021da9089d8f6b475e67710/ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
[modify] https://crrev.com/e797cbfd3a992c22b021da9089d8f6b475e67710/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/e797cbfd3a992c22b021da9089d8f6b475e67710/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

Comment 4 by lucmult@chromium.org, Jul 13

Status: Fixed (was: Assigned)

joelhockey@ helped debug this issue and we found out 2 small bugs on my change that reflected on these tests failing.

The CL on #3 fixed them. So this bug can be closed.

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/294f19fc3c16bf13983f85e8e5e1c7c14c4be554

commit 294f19fc3c16bf13983f85e8e5e1c7c14c4be554
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Jul 13 16:19:06 2018

Enable new-files-app-navigation by default

This CL reverses the value of the feature flag to mean enabled, and
fixes all tests to pass with the new My Files on navigation menu.

Change MyFiles tests to not append the flag anymore, because when the
flag is provided it now disables "My Files" :)

Fix navigation_list_model_unittest.js to pass flag true/false on
NavigationListModel with the desired flag state.

Stop calling "notifyEntriesChanged" on
DirectoryTree.updateSharedStatusIcon, because this causes the cache
invalidation, which was causing some metadata model to be invalidated
before being displayed on file list, in particular the modificationTime
column on file list.  crbug.com/857343  tracks further investigation if
this call was really still needed.

Change folder_shortcuts.js to account to new My Files on directory
tree, because it changes the keyboard shortcut to select top-level
directories. Also fix and improve some comments.

Change tab_index.js to account to My Files on breadcrumbs being focused
during tab cycle. This requires adding an id on breadcrumbs.

Bug:  857335 ,  862897 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iddb2545772e62c0e8adebd8b278bd3a5765f5040
Reviewed-on: https://chromium-review.googlesource.com/1131025
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574939}
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
[modify] https://crrev.com/294f19fc3c16bf13983f85e8e5e1c7c14c4be554/ui/file_manager/integration_tests/file_manager/tab_index.js

►

Issue 862897 link

Issue metadata

Fix FileManagerUITest interference between tests

Issue description

Comment 1 by lucmult@chromium.org, Jul 12

Comment 1 Deleted

Comment 2 by lucmult@chromium.org, Jul 12

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jul 13

Comment 3 Deleted

Comment 4 by lucmult@chromium.org, Jul 13

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jul 13

Comment 5 Deleted

Sign in to add a comment