Findit has detected flake occurrences for the test NetworkConnectionTrackerBrowserTest.SimulateNetworkServiceCrash Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzczMTY1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RtVjBkMjl5YTBOdmJtNWxZM1JwYjI1VWNtRmphMlZ5UW5KdmQzTmxjbFJsYzNRdVUybHRkV3hoZEdWT1pYUjNiM0pyVTJWeWRtbGpaVU55WVhObwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NetworkConnectionTrackerBrowserTest.SimulateNetworkServiceCrash&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzczMTY1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RtVjBkMjl5YTBOdmJtNWxZM1JwYjI1VWNtRmphMlZ5UW5KdmQzTmxjbFJsYzNRdVUybHRkV3hoZEdWT1pYUjNiM0pyVTJWeWRtbGpaVU55WVhObwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Findit identified the culprit r574314 with confidence 100.0% in the config "chromium.linux / Linux Tests (dbg)(1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzczMTY1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RtVjBkMjl5YTBOdmJtNWxZM1JwYjI1VWNtRmphMlZ5UW5KdmQzTmxjbFJsYzNRdVUybHRkV3hoZEdWT1pYUjNiM0pyVTJWeWRtbGpaVU55WVhObwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NetworkConnectionTrackerBrowserTest.SimulateNetworkServiceCrash&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzczMTY1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1RtVjBkMjl5YTBOdmJtNWxZM1JwYjI1VWNtRmphMlZ5UW5KdmQzTmxjbFJsYzNRdVUybHRkV3hoZEdWT1pYUjNiM0pyVTJWeWRtbGpaVU55WVhObwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/197e9188dc5be69cb34e1ebd67f86a1146439367 commit 197e9188dc5be69cb34e1ebd67f86a1146439367 Author: Mike West <mkwst@chromium.org> Date: Thu Jul 12 11:11:00 2018 Revert "Make NetworkConnectionTracker survive network service crashes and restarts" This reverts commit cec0800c372ef670f59999fb3f028013d36b866c. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww TBR=xunjieli@chromium.org Bug: 862883 Original change's description: > Make NetworkConnectionTracker survive network service crashes and restarts > > This CL is to mirror tbansal@'s CL > (https://chromium-review.googlesource.com/1058528) to make > NetworkConnectionTracker survice network service's crashes and restarts. > > Bug: 821009 > Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528 > Reviewed-on: https://chromium-review.googlesource.com/1120738 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574314} TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821009 Reviewed-on: https://chromium-review.googlesource.com/1135006 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#574523} [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/chrome/browser/net/network_connection_tracker_browsertest.cc [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/chrome/browser/net/network_quality_tracker_browsertest.cc [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/content/public/browser/network_connection_tracker.cc [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/content/public/browser/network_connection_tracker.h [modify] https://crrev.com/197e9188dc5be69cb34e1ebd67f86a1146439367/content/public/browser/network_connection_tracker_unittest.cc
Findit identified the culprit r574314 with confidence 100.0% in the config "chromium.linux / Linux Tests (dbg)(1)(32)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81MTMxNy9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cy9UbVYwZDI5eWEwTnZibTVsWTNScGIyNVVjbUZqYTJWeVFuSnZkM05sY2xSbGMzUXVVMmx0ZFd4aGRHVk9aWFIzYjNKclUyVnlkbWxqWlVOeVlYTm8MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NetworkConnectionTrackerBrowserTest.SimulateNetworkServiceCrash&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81MTMxNy9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cy9UbVYwZDI5eWEwTnZibTVsWTNScGIyNVVjbUZqYTJWeVFuSnZkM05sY2xSbGMzUXVVMmx0ZFd4aGRHVk9aWFIzYjNKclUyVnlkbWxqWlVOeVlYTm8MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d24ee7bc5a14573a8a761c45222f68efb4bef3b0 commit d24ee7bc5a14573a8a761c45222f68efb4bef3b0 Author: Helen Li <xunjieli@chromium.org> Date: Thu Jul 12 18:30:30 2018 Reland "Make NetworkConnectionTracker survive network service crashes and restarts" This reverts commit 197e9188dc5be69cb34e1ebd67f86a1146439367. Reason for revert: There is a racy test expectation that causes the test to timeout. This CL fixes the test. Bug: 862883 , 821009 Change-Id: I1cb4d8db6ea3f5c683f95bcc3187f6c6b4d6fdbd Reviewed-on: https://chromium-review.googlesource.com/1135290 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#574642} [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/chrome/browser/net/network_connection_tracker_browsertest.cc [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/chrome/browser/net/network_quality_tracker_browsertest.cc [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/content/public/browser/network_connection_tracker.cc [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/content/public/browser/network_connection_tracker.h [modify] https://crrev.com/d24ee7bc5a14573a8a761c45222f68efb4bef3b0/content/public/browser/network_connection_tracker_unittest.cc
Comment 1 by Findit
, Jul 12