New issue
Advanced search Search tips

Issue 862864 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 855791
issue 731433
issue 731479
issue 776250



Sign in to add a comment

Delete *_chromium_gn_upload builders under chromium.fyi

Project Member Reported by efoo@chromium.org, Jul 12

Issue description

For more context see crbug.com/776250#c7

These builders can be deleted once Chromium is flipped to consume GN as a CIPD package. 

Blocked on 855791. Do not delete until 855791 is closed. 

 
Status: Available (was: Untriaged)
Blockedon: 776250
Owner: efoo@chromium.org
Discussed with Dirk. Don't have to wait for 855791 to turn this down. Assigned to self for removing Buildbot builders. 
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/8f0291af1dc0835c658feb7b53ab1ce642805585

commit 8f0291af1dc0835c658feb7b53ab1ce642805585
Author: Eric Foo <efoo@chromium.org>
Date: Fri Aug 17 01:11:01 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3842a3b061343a107bd53bfb83a196abedbeec1e

commit 3842a3b061343a107bd53bfb83a196abedbeec1e
Author: Eric Foo <efoo@chromium.org>
Date: Fri Aug 17 04:40:19 2018

Delete *_chromium_gn_upload builders

Bug:  862864 
Change-Id: Idacfb439011488cfb472907c480fb49a704e24fc
Reviewed-on: https://chromium-review.googlesource.com/1173760
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583962}
[modify] https://crrev.com/3842a3b061343a107bd53bfb83a196abedbeec1e/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/3842a3b061343a107bd53bfb83a196abedbeec1e/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/3842a3b061343a107bd53bfb83a196abedbeec1e/tools/mb/mb_config.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3202010d9ac8b549a219cc90fdbd590d63a849b3

commit 3202010d9ac8b549a219cc90fdbd590d63a849b3
Author: Eric Foo <efoo@chromium.org>
Date: Fri Aug 17 18:37:14 2018

Delete *_chromium_gn_upload builders

Bug:862864
Change-Id: I5c11276ae876678d012f83f03fdc9fb8527c00f6
Reviewed-on: https://chromium-review.googlesource.com/1173761
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win_chromium_gn_upload.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.mac/slaves.cfg
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_luci_infra_internal_prod_gn_builder_win.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.win/master.cfg
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_mac_mac_chromium_gn_upload.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.win/slaves.cfg
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.linux/master.cfg
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.py
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_luci_infra_internal_prod_gn_builder_linux.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.mac/master.cfg
[delete] https://crrev.com/0fd1d8ae5bfb86756f73b441f05604042144c9b9/scripts/slave/recipes/chromium_gn_upload.expected/full_luci_infra_internal_prod_gn_builder_mac.json
[modify] https://crrev.com/3202010d9ac8b549a219cc90fdbd590d63a849b3/masters/master.tryserver.chromium.linux/slaves.cfg

Status: Fixed (was: Available)

Comment 8 by thakis@google.com, Jan 17 (5 days ago)

They're still in https://chromium.googlesource.com/chromium/src/+/refs/meta/config/buildbucket.config and hence still show up on the trybot selector on gerrit. Can you remove them there too please?

Comment 9 by thakis@google.com, Jan 17 (5 days ago)

(keywords linux_chromium_gn_upload _gn_upload mac_chromium_gn_upload win8_chromium_gn_upload win_chromium_gn_upload )

Sign in to add a comment