New issue
Advanced search Search tips

Issue 862863 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Nov 13
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Componentize the bottom toolbar buttons

Project Member Reported by amaralp@chromium.org, Jul 12

Issue description

Move the bottom toolbar buttons to their own MVC components.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c59b348ffef08cfdca20701f4f54236f9e6e295

commit 4c59b348ffef08cfdca20701f4f54236f9e6e295
Author: Pedro Amaral <amaralp@chromium.org>
Date: Thu Jul 12 19:03:11 2018

Making a menu button component

Pulling the menu button out of the bottom toolbar component into its
own class.

Bug:  862863 


Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
Reviewed-on: https://chromium-review.googlesource.com/1132423
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574658}
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/res/layout/menu_button.xml
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
[add] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
[modify] https://crrev.com/4c59b348ffef08cfdca20701f4f54236f9e6e295/chrome/android/java_sources.gni

Labels: M-70
Mergedinto: 871806
Status: Duplicate (was: Started)

Sign in to add a comment