New issue
Advanced search Search tips

Issue 862859 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Flaky-Test: TabDragging/DetachToBrowserTabDragControllerTest.DetachToOwnWindow/0



Sign in to add a comment

TabDragging/DetachToBrowserTabDragControllerTest.DetachToOwnWindow/0 is Flaky

Project Member Reported by Findit, Jul 12

Issue description

Owner: erikc...@chromium.org
Erik, could you see if this is related to some of the work you did in the test earlier? (context: https://chromium-review.googlesource.com/c/chromium/src/+/1132106)
Status: Started (was: Available)
Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b20bb048913985eae71b480db2a2017173ef73a2

commit b20bb048913985eae71b480db2a2017173ef73a2
Author: erikchen <erikchen@chromium.org>
Date: Thu Jul 12 20:16:25 2018

Remove assertion from DetachToOwnWindow on macOS 10.10.

On macOS 10.10, AppKit appears to use the test's generated events to
asynchronously reactivate the first window. There's no way to tell when this
asynchronous reactivation will happen, so just avoid checking the assertion in
the test. This problem appears constrained to how we generate test events, and
not to the actual behavior of Chrome.

Bug:  862859 
Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
Reviewed-on: https://chromium-review.googlesource.com/1135305
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574699}
[modify] https://crrev.com/b20bb048913985eae71b480db2a2017173ef73a2/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

is this fixed?
Cc: kylixrd@chromium.org peria@chromium.org
 Issue 883205  has been merged into this issue.
Labels: OS-Mac
Status: Fixed (was: Started)
Should be fixed. Note that this was macOS only

Sign in to add a comment