New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862842 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Jul 18
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Find results are blocked by VK.

Project Member Reported by shend@chromium.org, Jul 12 
Chrome Version: 69.0.3488.0
OS: ChromeOS Eve

What steps will reproduce the problem?
(1) Go to a website in tablet mode.
(2) Search for some text.
(3) Navigate through the results.

What is the expected result?
Can always see the result on the screen.

What happens instead?
Some results are blocked by the virtual keyboard.

See attached video.
find.webm
3.8 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8e3b891dfa11569d2f6adf28f2d615141ba70e

commit bb8e3b891dfa11569d2f6adf28f2d615141ba70e
Author: Darren Shen <shend@chromium.org>
Date: Fri Jul 13 03:55:35 2018

Make find in page use visual viewport instead of layout viewport.

Currently, when we cycle through results in find in page, we ensure that
the current result is visible by scrolling if the result is off-screen.
We currently use the layout viewport as an indication of what's visible
on the screen. However, layout viewport does not include the virtual
keyboard on ChromeOS. This means that on a tablet, the current result
may be hidden by the virtual keyboard.

We change find in page to use the visual viewport instead, which takes
into account region occluded by the virtual keyboard, so the current
result is always visible even when the virtual keyboard is up.

Bug:  862842 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I10e52091fb54617ae3d0222130cd1c22699117f5
Reviewed-on: https://chromium-review.googlesource.com/1134722
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574829}
[modify] https://crrev.com/bb8e3b891dfa11569d2f6adf28f2d615141ba70e/third_party/blink/renderer/core/editing/finder/text_finder.cc

Comment 2 by shend@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment