New issue
Advanced search Search tips

Issue 862839 link

Starred by 1 user
Status: Duplicate
Merged: issue 784164
Owner:
aee@chromium.org
Closed: Jan 7
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebUI: Ctrl+F focuses toolbar search box for main chrome pages

Project Member Reported by aee@chromium.org, Jul 12 
Settings, Downloads and History do this already. Settings uses a different (preferable) approach to Downloads and History. Downloads/History use the command tag to capture and handle the key events.

Extensions and Bookmarks have no implementation to do this.

I propose we have one reusable approach that is used across the main chrome:// pages.

Comment 1 by aee@chromium.org, Dec 28

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797

commit 2e4f7f7e72cc8a720d1a76791d97d4008d8c4797
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Jan 03 19:48:39 2019

WebUI: move FindShortcutBehavior to common webui/resources

Bug:  862839 
Change-Id: I3499e9c6abe18c0ffb23a4ed3598320edf757570
Reviewed-on: https://chromium-review.googlesource.com/c/1392063
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619722}
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/BUILD.gn
[delete] https://crrev.com/e80f9a52cf0708b1a01cb4d75617132dc3b1ae56/chrome/browser/resources/settings/find_shortcut_behavior.html
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/languages_page/BUILD.gn
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_page/BUILD.gn
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_page/settings_subpage.js
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_ui/BUILD.gn
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/test/data/webui/find_shortcut_behavior_browsertest.js
[rename] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/test/data/webui/find_shortcut_behavior_test.js
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/ui/webui/resources/cr_polymer_resources.grdp
[add] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/ui/webui/resources/html/find_shortcut_behavior.html
[modify] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/ui/webui/resources/js/BUILD.gn
[rename] https://crrev.com/2e4f7f7e72cc8a720d1a76791d97d4008d8c4797/ui/webui/resources/js/find_shortcut_behavior.js

Comment 5 by aee@chromium.org, Jan 7

Mergedinto: 784164
Status: Duplicate (was: Started)
►

Sign in to add a comment