Excessive "ensure_bootstrap" calls in cbuildbot_launch/cbuildbot? |
||
Issue descriptionWhile diagnosing this bug: https://crbug.com/769369 We added calls to "ensure_bootstrap" for depot_tools to the cbuildbot_launcher (https://crrev.com/c/691258), InitSdkStage (https://crrev.com/c/692985), and later into update_chroot (https://crrev.com/c/803196). Is there any reason to keep it anywhere other than in update_chroot? I'd like to delete the calls from the other locations to make things simpler.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/27998f7634952db7c3efad48d0a6797bf796e4a9 commit 27998f7634952db7c3efad48d0a6797bf796e4a9 Author: Don Garrett <dgarrett@google.com> Date: Thu Jul 12 21:06:15 2018 cbuildbot_launch/InitSdk: Remove DepotToolsEnsureBootstrap. Since we are calling ensure_bootstrap in depot_tools in update_chroot (CL:803196), we shouldn't need it in these other two locations. BUG= chromium:862834 TEST=run_tests Change-Id: I489e8cf96a28249d2915e85a147d7c1ec796e715 Reviewed-on: https://chromium-review.googlesource.com/1134569 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/27998f7634952db7c3efad48d0a6797bf796e4a9/cbuildbot/stages/build_stages.py [modify] https://crrev.com/27998f7634952db7c3efad48d0a6797bf796e4a9/scripts/cbuildbot_launch.py [modify] https://crrev.com/27998f7634952db7c3efad48d0a6797bf796e4a9/scripts/cbuildbot_launch_unittest.py
,
Jul 12
|
||
►
Sign in to add a comment |
||
Comment 1 by dgarr...@chromium.org
, Jul 12Status: Started (was: Untriaged)