New issue
Advanced search Search tips

Issue 862826 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug
Flaky-Test: external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html



Sign in to add a comment

"external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 11

Issue description

"external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycwsSBUZsYWtlImhleHRlcm5hbC93cHQvaHRtbC9zeW50YXgvcGFyc2luZy90ZW1wbGF0ZS9jcmVhdGluZy1hbi1lbGVtZW50LWZvci10aGUtdG9rZW4vdGVtcGxhdGUtb3duZXItZG9jdW1lbnQuaHRtbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Blink>HTML>CustomElements
Labels: OS-Linux OS-Mac
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/704b3f013b80c7a5f93296e3d146758d5c0b0ccc

commit 704b3f013b80c7a5f93296e3d146758d5c0b0ccc
Author: Mike West <mkwst@chromium.org>
Date: Thu Jul 12 12:44:57 2018

Mark several layout tests as flaky.

- css3/filters/effect-brightness-clamping-hw.html
- virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
- css3/filters/effect-drop-shadow-hw.html
- external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html

TBR=kpaulhamus@chromium.org

Bug: 862716,  862729 , 862806,  862826 
Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
Reviewed-on: https://chromium-review.googlesource.com/1134990
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574539}
[modify] https://crrev.com/704b3f013b80c7a5f93296e3d146758d5c0b0ccc/third_party/WebKit/LayoutTests/TestExpectations

Cc: ratsu...@gmail.com
Labels: -Sheriff-Chromium
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Kent but CC'ing Sunny. 
Sunny, it looks like you were working near this recently. Could you take a look?
Cc: tkent@chromium.org
Components: -Blink>HTML>CustomElements Blink>HTML>Parser
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
It seems the test is just slow. We should add <meta name="timeout" content="long"> to the test.

Project Member

Comment 5 by Findit, Sep 22

Flaky-Test: external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
Labels: Test-Flaky Test-Findit-Detected Sheriff-Chromium

external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html is flaky.

Findit has detected 3 new flake occurrences of this test. List
of all flake occurrences can be found at:
https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVykQELEgVGbGFrZSKFAWNocm9taXVtQHdlYmtpdF9sYXlvdXRfdGVzdHNAZXh0ZXJuYWwvd3B0L2h0bWwvc3ludGF4L3BhcnNpbmcvdGVtcGxhdGUvY3JlYXRpbmctYW4tZWxlbWVudC1mb3ItdGhlLXRva2VuL3RlbXBsYXRlLW93bmVyLWRvY3VtZW50Lmh0bWwM.

Since this test is still flaky, this issue has been moved back onto the Sheriff
Bug Queue if it's not already there.

If the result above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVykQELEgVGbGFrZSKFAWNocm9taXVtQHdlYmtpdF9sYXlvdXRfdGVzdHNAZXh0ZXJuYWwvd3B0L2h0bWwvc3ludGF4L3BhcnNpbmcvdGVtcGxhdGUvY3JlYXRpbmctYW4tZWxlbWVudC1mb3ItdGhlLXRva2VuL3RlbXBsYXRlLW93bmVyLWRvY3VtZW50Lmh0bWwM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Owner: tkent@chromium.org
Status: Assigned (was: Available)
this is still flaking, even though the expectations are marked as [ Failure Pass ]. I suppose this is because it also times out. As per #4, should we add that meta tag instead of adjusting the expectations?
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2736bb6e8702f30b88f81ecc7c91de71c415b962

commit 2736bb6e8702f30b88f81ecc7c91de71c415b962
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Sep 27 05:08:45 2018

html: Mark template-owner-document.html slow.

This tests parsing behavior for all element types with <template>.

Bug:  862826 
Change-Id: Iaa1c0f5bdeed26e0a32ae627ae388503b33a972d
Reviewed-on: https://chromium-review.googlesource.com/1248064
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594596}
[modify] https://crrev.com/2736bb6e8702f30b88f81ecc7c91de71c415b962/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2736bb6e8702f30b88f81ecc7c91de71c415b962/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html

Status: Fixed (was: Started)

Sign in to add a comment