New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862807 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Participants' hotlists:
ML-Service


Sign in to add a comment

ML Service: Document how clients should publish models

Project Member Reported by amoylan@chromium.org, Jul 11

Issue description

We need a document describing how clients can add a model accessible to ML Service.

At first, for this bug, this needs to describe how to add "system" models. 

Later, this documentation can expand to cover things like:
- DLC/component updater models
- TF vs TF Lite considerations
- What kinds of automated testing occur / requirements for that
- How to call the models (using the Chromium client library under development)

 
Cc: napper@chromium.org claudiomagni@chromium.org martis@chromium.org amoylan@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c444a9c3c2eb11ed9a143dea81f30c52bc8a0b6b

commit c444a9c3c2eb11ed9a143dea81f30c52bc8a0b6b
Author: Claudio M <claudiomagni@chromium.org>
Date: Wed Aug 29 18:16:11 2018

ml: Add documentation for ML Service

In particular, this documentation will help Google teams perform
inference with ML Service. The main instructions cover how to publish a
model to make it available for ML Service at runtime.

BUG= chromium:862807 
TEST=none

Change-Id: Ic42ffda220eb8c01234663f872b86bed294688fa
Reviewed-on: https://chromium-review.googlesource.com/1141561
Commit-Ready: Claudio M <claudiomagni@chromium.org>
Tested-by: Claudio M <claudiomagni@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>

[add] https://crrev.com/c444a9c3c2eb11ed9a143dea81f30c52bc8a0b6b/ml/docs/publish_model.md
[modify] https://crrev.com/c444a9c3c2eb11ed9a143dea81f30c52bc8a0b6b/ml/README.md

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4c4bc7dc38f2f4913808f97af39da89380f6f1f2

commit 4c4bc7dc38f2f4913808f97af39da89380f6f1f2
Author: Andrew Moylan <amoylan@chromium.org>
Date: Tue Dec 18 04:47:05 2018

ml: Document .cc changes needed for new models

This CL expands the model publishing documentation to also describe the
changes needed to the ML Service daemon .cc code, using pmalani's
SMART_DIM port as the guiding example.

BUG= chromium:862807 ,chromium:893425
TEST=no

Change-Id: I24b469314dbd314c57476bee215badf42abf327e
Reviewed-on: https://chromium-review.googlesource.com/1379631
Commit-Ready: Andrew Moylan <amoylan@chromium.org>
Tested-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Claudio M <claudiomagni@chromium.org>

[modify] https://crrev.com/4c4bc7dc38f2f4913808f97af39da89380f6f1f2/ml/docs/publish_model.md

Sign in to add a comment