Failed Tether ConnectTethering connection results in confusing UI modal |
||||
Issue descriptionObserved on ToT. Repro: 1) Open Mobile Data Settings (in Settings, not Quick Settings -- this bug only manifests if Mobile Data Settings is open) 2) Perform a successful host scan (device appears in Mobile Data list) 3) Disable cell data on the phone (in order to make the ConnectTetheringRequest fail) 4) Select the phone in the UI to begin a connection 5) Observe. A confusing modal is displayed that just says "Configure phone" which offers to connect to the phone again (doesn't seem helpful). Screenshot included.
,
Jul 11
Yes, it is the network configuration dialog. It looks like somewhere along the 'connect to network' code path, the network is identified as unconfigure / non connectable, so we open a configure dialog. We should probably not do that for Tether networks :)
,
Nov 30
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc2560eb9f1a167f2e3d636a9977eecebf060b7c commit cc2560eb9f1a167f2e3d636a9977eecebf060b7c Author: Regan Hsu <hsuregan@chromium.org> Date: Mon Dec 03 19:19:42 2018 [CrOS IntantTethering] Remove UI modal on failed tether connection Remove unhelpful UI modal that is displayed that just says "Configure phone" which offers to connect to the phone again. It doesn't seem to be helpful. Bug: 862794 Change-Id: I6637d9b9931f0ca1b38b6d57b9326a806dee923e Reviewed-on: https://chromium-review.googlesource.com/c/1357529 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613186} [modify] https://crrev.com/cc2560eb9f1a167f2e3d636a9977eecebf060b7c/chrome/browser/resources/settings/internet_page/internet_page.js
,
Dec 3
|
||||
►
Sign in to add a comment |
||||
Comment 1 by khorimoto@chromium.org
, Jul 11