New issue
Advanced search Search tips

Issue 862792 link

Starred by 1 user
Status: Assigned
Owner:
dpa...@chromium.org
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ESLint PRESUBMIT error output appears malformed.

Project Member Reported by dpa...@chromium.org, Jul 11 
I recently noticed that some PRESBUMIT messages appear malformed when viewed via a URL, for example https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941350768013031296%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout.

I am also pasting below (see weird_encoding.png screenshot), in case the URL above stops working.

** Presubmit ERRORS **
/b/swarming/w/ir/cache/builder/chromium_presubmit/src/chrome/test/data/webui/extensions/extension_detail_view_test.js
  302:7  error  Unexpected var, use let or const instead  no-var
  304:7  error  Unexpected var, use let or const instead  no-var
  313:7  error  Unexpected var, use let or const instead  no-var
  318:7  error  Unexpected var, use let or const instead  no-var
  343:7  error  Unexpected var, use let or const instead  no-var
  345:7  error  Unexpected var, use let or const instead  no-var
  354:7  error  Unexpected var, use let or const instead  no-var
  360:9  error  Unexpected var, use let or const instead  no-var
  361:9  error  Unexpected var, use let or const instead  no-var
✖ 9 problems (9 errors, 0 warnings)



Attaching correct_encoding.png screenshot where it shows how this normally appears through a terminal.
weird_encoding.png
81.0 KB View Download
correct_encoding.png
21.7 KB View Download

Comment 1 by hinoka@chromium.org, Jul 11 

Those look like terminal color control codes.  Either the butler is presenting its pipe with the wrong capabilities, or eslint can't detect it correctly.

Comment 2 by dpa...@chromium.org, Jul 12 

I recall that the error output looked fine a few months ago, so maybe this is related to the migration to LUCI/LogDog?

Comment 3 by mar...@chromium.org, Jul 26

Components: -Infra>Platform>LogDog UI>Browser>WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Please make sure that the tool is not printing ANSI color codes unexpectedly.

Comment 4 by dpa...@chromium.org, Jul 26 

@maruel: When I run it locally the output of the tool looks as in the attached correct_encoding.png. I am not sure how to further test what you are asking.

Comment 5 by dpa...@chromium.org, Jul 26 

The invocation of the tool happens at https://cs.chromium.org/chromium/src/tools/web_dev_style/js_checker.py?l=81-85. Perhaps removing the --color flag would fix the issue?

Comment 6 by dpa...@chromium.org, Jul 26 

Or perhaps changing the --format flag to a different option from https://eslint.org/docs/user-guide/formatters/.

But having said  that, the question still remains, on why this used to work before but does not work anymore.
►

Sign in to add a comment