New issue
Advanced search Search tips

Issue 862791 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

dragging arc++ window to another display may move the window back to source display

Project Member Reported by osh...@chromium.org, Jul 11

Issue description

Dom is working on long term fix, but I have a short term fix that
fixes most cases.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caf225a5b277397876aa62a44eb20effe52681ac

commit caf225a5b277397876aa62a44eb20effe52681ac
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jul 12 21:49:37 2018

Eliminate unnecessary bounds change request

* ClientControlled do not have to have a new bounds when
  window is moved to another tree beucase the bounds will
  be controlled by a client. (window_positioning_utility.cc)
* Update bounds locally when the window is added to another display.
* Do not move the display if the bounds is set by geometry change.
  This scenario isn't important right now and will be fixed by
  neww api.

Bug:  862791 , b/110171997
TEST: will be covered by a unit test in a separate CL.
Change-Id: I2be5748661c680fb35bdaa1d25a2bd209edc4a7d
Reviewed-on: https://chromium-review.googlesource.com/1134419
Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574737}
[modify] https://crrev.com/caf225a5b277397876aa62a44eb20effe52681ac/ash/wm/client_controlled_state.cc
[modify] https://crrev.com/caf225a5b277397876aa62a44eb20effe52681ac/ash/wm/client_controlled_state.h
[modify] https://crrev.com/caf225a5b277397876aa62a44eb20effe52681ac/ash/wm/client_controlled_state_unittest.cc
[modify] https://crrev.com/caf225a5b277397876aa62a44eb20effe52681ac/ash/wm/window_positioning_utils.cc
[modify] https://crrev.com/caf225a5b277397876aa62a44eb20effe52681ac/components/exo/client_controlled_shell_surface.cc

Labels: Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 12

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eae60a77ebac39e53e024eac464181e38697d30

commit 9eae60a77ebac39e53e024eac464181e38697d30
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Jul 13 19:45:07 2018

Unit test for crrev.com/c/1134419

THis also makes the test behavior closer to
actual behavior.

Bug:  862791 , b/110171997
Test: Covered by unit tests
Change-Id: I289a28d99ac8aee39218ff65fc5095de21b226c5
Reviewed-on: https://chromium-review.googlesource.com/1135759
Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575026}
[modify] https://crrev.com/9eae60a77ebac39e53e024eac464181e38697d30/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/9eae60a77ebac39e53e024eac464181e38697d30/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/9eae60a77ebac39e53e024eac464181e38697d30/components/exo/test/test_client_controlled_state_delegate.cc

the merge request is for the CL in #1
Please mark OS
Labels: OS-Chrome
Labels: -Merge-Review-68 Merge-Approved-67
Labels: -Hotlist-Merge-Review -Merge-Approved-67 Merge-Approved-68
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 17

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c

commit 9bb1cc78787bd8200b2e643b16f27f8a02e14a1c
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Jul 17 05:34:17 2018

Eliminate unnecessary bounds change request

* ClientControlled do not have to have a new bounds when
  window is moved to another tree beucase the bounds will
  be controlled by a client. (window_positioning_utility.cc)
* Update bounds locally when the window is added to another display.
* Do not move the display if the bounds is set by geometry change.
  This scenario isn't important right now and will be fixed by
  neww api.

(cherry picked from commit caf225a5b277397876aa62a44eb20effe52681ac)

Bug:  862791 , b/110171997
TEST: will be covered by a unit test in a separate CL.
Change-Id: I2be5748661c680fb35bdaa1d25a2bd209edc4a7d
Reviewed-on: https://chromium-review.googlesource.com/1134419
Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#574737}
Reviewed-on: https://chromium-review.googlesource.com/1139574
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#690}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c/ash/wm/client_controlled_state.cc
[modify] https://crrev.com/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c/ash/wm/client_controlled_state.h
[modify] https://crrev.com/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c/ash/wm/client_controlled_state_unittest.cc
[modify] https://crrev.com/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c/ash/wm/window_positioning_utils.cc
[modify] https://crrev.com/9bb1cc78787bd8200b2e643b16f27f8a02e14a1c/components/exo/client_controlled_shell_surface.cc

Status: Fixed (was: Started)

Sign in to add a comment