New issue
Advanced search Search tips

Issue 862752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

ToolbarFirstFocusStartupState ignores urlbar focus before native is loaded

Project Member Reported by mheikal@chromium.org, Jul 11

Issue description

Urlbar/omnibox focus events that are used for UMAs ("MobileStartup.ToolbarFirstFocusStartupState.<activity name>" and "MobileStartup.ToolbarFirstFocusTime2.<activity name>"), that happen before native is loaded, are ignored.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79bb954dd2e807d3fac32e2b4fa14046770ef00a

commit 79bb954dd2e807d3fac32e2b4fa14046770ef00a
Author: Mohamed Heikal <mheikal@google.com>
Date: Wed Jul 11 22:02:41 2018

[UMA] Fix bug were omnibox focus is ignored before native is loaded

Urlbar/omnibox focus events that are used for UMAs
("MobileStartup.ToolbarFirstFocusStartupState.<activity name>" and
"MobileStartup.ToolbarFirstFocusTime2.<activity name>"), that happen
before native is loaded, are ignored. This was due to the improper
placement of the call to OmniboxStartupMetrics#onUrlBarFocused.

Bug:  862752 
Change-Id: I7354be526b1c116ef9b541a4d5993058163d22a1
Reviewed-on: https://chromium-review.googlesource.com/1134184
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574357}
[modify] https://crrev.com/79bb954dd2e807d3fac32e2b4fa14046770ef00a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Assigned)

Sign in to add a comment