New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862742 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

mb.py's analyze feature finds dependencies for OWNERS files

Project Member Reported by ddorwin@chromium.org, Jul 11

Issue description

mb.py's analyze feature causes CLs that contain only OWNERS files to compile and run tests.

As an example, https://crrev.com/c/1121097 contains only OWNERS files but the analyze step on many of the bots "Found dependency" and even some bots that found "No dependency" still compiled, possibly due to analyze_matched_exclusion.

Specifically:
1. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_arm64_dbg_recipe/70470:
  * Appears to have found many compile_targets and four test_targets.
  * analyze_matched_exclusion Analyze disabled: matched exclusion
2. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_chromium_compile_dbg_ng/75880:
  * Appears to have found five test_targets.
  * analyze_matched_exclusion Analyze disabled: matched exclusion
3. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_vr/1252:
  * The analyze step found "No dependency", but, unlike issue 862731, it did not report "No compile necessary" in the steps overview. Maybe that is because of the next item, though it's strange that the next item does not run in that case.
  * analyze_matched_exclusion Analyze disabled: matched exclusion

All of the "analyze_matched_exclusion Analyze disabled: matched exclusion" were:
tools/perf/contrib/vr_benchmarks/OWNERS (regex = 'tools/perf/.*')

Does this mean that changing any file under tools/perf/ will force a compile? This doesn't appear to be the only problem, though, since the first two bots above found compile and/or test targets.
 
Cc: estaab@chromium.org
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
dpranke, do you know what component is used for mb issues?
Components: -Infra Infra>Client>Chrome Build
In these examples, we're actually bypassing MB's analyze feature (meaning that we run analyze but ignore the results; that's what the "matched exclusion" means).

> Does this mean that changing any file under tools/perf/ will force a compile?

Yes, the entry in //testing/buildbot/trybot_analyze_config.json for tools/perf/.* means that changing any file under //tools/perf will cause everything to be rebuilt. Clearly we could be smarter about this. 

> This doesn't appear to be the only problem, though, since the first
> two bots above found compile and/or test targets.

I don't follow this comment, though; it looks like they're all hitting the same exclusion. Maybe you were confused by the build log?

Bugs against MB go into the "Build" component, This isn't a bug in MB, but "Build" is probably a good component for it anyway, that or Infra>Client>Chrome.


Cc: liaoyuke@chromium.org dpranke@chromium.org martiniss@chromium.org nednguyen@chromium.org
Labels: -Restrict-View-Google
Owner: ddorwin@chromium.org
As written, things WAI. Perhaps we should file a new bug to tighten up the whitelist, though. ddorwin, what do you want to do here?
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment