Focus ring around update pending icon gets squashed during resolution change |
|||||||||||||||
Issue descriptionChrome Version : 69.0.3487.0 OS Version: 10.0 What steps will reproduce the problem? 1. Get "update pending" error while attached to external display 2. Disconnect from display 3. Observe screenshot1 - focus ring is squashed on right side 4. Click maximize window twice 5. Focus ring is fixed 6. Maximize again 7. Observe screenshot2 - one focus ring is correct and the other is offset UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3487.0 Safari/537.36
,
Jul 12
,
Jul 17
Upgrading to P1
,
Jul 17
,
Jul 19
,
Jul 19
This should be fairly infrequent (happens on update request) and goes away when the dialog is dismissed. This would actually take quite a bit of inkdrop restructuring to fix and I don't think we have time to do that for 69. Dropping prio as this should be a low-frequency (esp. for stable) cosmetic thing.
,
Jul 19
,
Jul 19
,
Jul 26
,
Aug 1
,
Aug 27
,
Sep 20
,
Sep 26
,
Oct 16
Hey pbos. If the relaunch recommended bubble is the thing that's causing the inkdrop, then you'll need to set the RelaunchNotification policy to 1 (check chrome://policy to see what it is). If you're running a local build, you may as well just edit ReadPreference in relaunch_notification_controller.cc so it unconditionally returns RelaunchNotificationSetting::kRecommendedBubble. Once you've got the policy squared away, launching with --simulate-upgrade (rather than critical-update) should make Chrome think a relaunch is needed for an update, triggering the bubble. I see some other hits for AnimateInkDrop in this query: https://cs.chromium.org/search/?q=AnimateInkDrop+file:src/chrome/browser&sq=package:chromium&type=cs, so maybe there is an easier way to provoke an inkdrop. I don't know of one off the top of my head.
,
Nov 26
**UI Mass triage** Adding appropriate labels based on #14
,
Dec 11
,
Dec 18
Issue 669253 has been merged into this issue. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by pbos@chromium.org
, Jul 11