New issue
Advanced search Search tips

Issue 862734 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug


Participants' hotlists:
pbos-backlog


Sign in to add a comment

Focus ring around update pending icon gets squashed during resolution change

Project Member Reported by rpop@chromium.org, Jul 11

Issue description

Chrome Version       : 69.0.3487.0
OS Version: 10.0

What steps will reproduce the problem?
1. Get "update pending" error while attached to external display
2. Disconnect from display
3. Observe screenshot1 - focus ring is squashed on right side
4. Click maximize window twice
5. Focus ring is fixed
6. Maximize again
7. Observe screenshot2 - one focus ring is correct and the other is offset


UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3487.0 Safari/537.36



 
Screenshot1.png
17.5 KB View Download
Screenshot2.png
27.3 KB View Download
Notes:

* This can be repro'd by supplying --simulate-upgrade and maximizing / restoring the window.
* This likely happens because the inkdrop uses different insets in restored / maximized mode (so it won't visibly extend to the browser edge even though the clickable area does).
* This affects the upgrade path as the inkdrop remains active even though the window is resized and uses the old insets that are incorrect for the new button size.
Labels: Proj-MdRefresh
Labels: -Pri-2 Group-Avatar_Button Pri-1
Upgrading to P1
Labels: -Hotlist-Teamfood-Feedback
Labels: -Group-Avatar_Button
Labels: -Pri-1 Hotlist-Polish Pri-3
This should be fairly infrequent (happens on update request) and goes away when the dialog is dismissed. This would actually take quite a bit of inkdrop restructuring to fix and I don't think we have time to do that for 69. Dropping prio as this should be a low-frequency (esp. for stable) cosmetic thing.
Labels: Group-Toolbar
Components: UI>Browser>Toolbar
Owner: ----
Status: Available (was: Assigned)
Labels: M-70 Target-70
Owner: pbos@chromium.org
Status: Assigned (was: Available)
Labels: -M-70 -Target-70 M-71 Target-71
Labels: -Proj-MdRefresh Proj-DesktopUI
Labels: Hotlist-DesktopUITriaged
Hey pbos. If the relaunch recommended bubble is the thing that's causing the inkdrop, then you'll need to set the RelaunchNotification policy to 1 (check chrome://policy to see what it is). If you're running a local build, you may as well just edit ReadPreference in relaunch_notification_controller.cc so it unconditionally returns RelaunchNotificationSetting::kRecommendedBubble. Once you've got the policy squared away, launching with --simulate-upgrade (rather than critical-update) should make Chrome think a relaunch is needed for an update, triggering the bubble.

I see some other hits for AnimateInkDrop in this query: https://cs.chromium.org/search/?q=AnimateInkDrop+file:src/chrome/browser&sq=package:chromium&type=cs, so maybe there is an easier way to provoke an inkdrop. I don't know of one off the top of my head.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
**UI Mass triage**

Adding appropriate labels based on #14
Labels: -M-71 -Target-71 M-73 Target-73
Issue 669253 has been merged into this issue.

Sign in to add a comment