New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862730 link

Starred by 1 user
Status: Fixed
Owner:
simonhatch@chromium.org
Closed: Jul 12
Cc:
benjhayden@chromium.org
eyaich@chromium.org
█ eakuefner@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Dashboard - All uploads failing

Project Member Reported by simonhatch@chromium.org, Jul 11 
Investigating this, migrated to the newest version and every upload in the last hour has failed.

I suspect it was all the changes to the api_request_handler in https://chromium-review.googlesource.com/c/catapult/+/1095657

I'm poking through the CL and I think we need to add a check in here: https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/common/utils.py#L55 for /add_histograms?

Ben, does that sound right?
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/1af68170e543102499b0b9be0351a5ffa6e21da2

commit 1af68170e543102499b0b9be0351a5ffa6e21da2
Author: Simon <simonhatch@chromium.org>
Date: Wed Jul 11 20:55:41 2018

Dashboard - Use oauth scopes for /add_histograms

Bug:  chromium:862730 
Change-Id: I2eb76abff6dcc3997d339d40585164aba64cbfc2
Reviewed-on: https://chromium-review.googlesource.com/1134031
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/1af68170e543102499b0b9be0351a5ffa6e21da2/dashboard/dashboard/common/utils.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/720dadbc215c229ce100bc408edb3aee03b0697e

commit 720dadbc215c229ce100bc408edb3aee03b0697e
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 11 22:44:29 2018

Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543


git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms


Created with:
  gclient setdep -r src/third_party/catapult@1af68170e543

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:862730 ,chromium:862666
TBR=sullivan@chromium.org

Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
Reviewed-on: https://chromium-review.googlesource.com/1133869
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574387}
[modify] https://crrev.com/720dadbc215c229ce100bc408edb3aee03b0697e/DEPS

Comment 3 by simonhatch@chromium.org, Jul 12

Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment