New issue
Advanced search Search tips

Issue 862726 link

Starred by 1 user
Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

MIPS build fails because of missing support for MIPS in crashpad

Reported by djordje....@mips.com, Jul 11 
UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Steps to reproduce the problem:
1. get depot_tools; fetch chromium
2. gn gen out/Release --args=" target_os=\"linux\" target_cpu=\"mipsel\""
3. ninja -C out/Release

What is the expected behavior?

What went wrong?
Build fails because of missing supporf for MIPS in crashpad

Did this work before? N/A 

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 30.0 r0

MIPS support for crashpad has been added in following commit:
https://chromium.googlesource.com/crashpad/crashpad/+/cb41ba7471a02113447f621027bc08a75b35be11
but it still needs to be rolled into chromium source tree.

Cherry picking above commit into src/third_party/crashpad/crashpad or running src/third_party/crashpad/update.py script fixes this issue for mips.

Comment 1 by krajshree@chromium.org, Jul 12

Labels: Needs-Milestone

Comment 2 by jmukthavaram@chromium.org, Jul 12

Labels: TE-NeedsTraige-help
Seems it is out of scope from TE end, adding TE-NeedsTraige-help label to move this out of our triaging bucket.

Could someone from dev team please take a look into this issue.
Thanks..!

Comment 3 by djordje....@mips.com, Jul 12 

Proposed fix: crrev.com/c/1134777

Comment 4 by dtapu...@chromium.org, Jul 12

Components: Internals>CrashReporting
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb

commit 43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb
Author: Djordje Golubovic <djordje.golubovic@mips.com>
Date: Mon Jul 16 16:51:21 2018

Update Crashpad to fb0f7ca8d7eb55ca51b77eb89813a3283a461b0c

fec77b759378 win: Add optional cipd pull of Windows toolchain package
b0de1cff1b6f win: Move cipd toolchain pull to subdirectory of
             third_party/win
d5ab4e21c6b7 Roll mini_chromium to 793e94e2
17dff19b216b fuchsia: Re-enable the trybots in compile-only config;
             enable arm64
4b05be4265c0 linux: fix ARM snapshot context traits build
b1692957029d linux: include missing ucontext header
eb7d8a4cde17 Alias user regs structs for glibc ARM64 pre 2.20
aabc485b646b fuchsia: Use ZX_TIME_INFINITE instead of UINT64_MAX
038ba6eea2b2 compat.gyp: use type=none for header-only target
3072b4059fbe zlib.gyp: support the "external" dependency mode
cb41ba7471a0 Added MIPS support to crashpad
1e504474a041 linux: Get exe name from main arguments
0c8f035a500a linux, non-glibc: fix build after eb7d8a4c
fb0f7ca8d7eb Uninstall handlers for expected crash signals in child
             processes

R=rsesek@chromium.org

Bug: 862726
Change-Id: I621a00988aa4415d9b6188b9738c856e74e8fd27
Reviewed-on: https://chromium-review.googlesource.com/1134777
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575309}
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/README.chromium
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/AUTHORS
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/compat/BUILD.gn
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/compat/compat.gyp
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h
[add] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/compat/linux/sys/user.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/minidump_context.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/minidump_context_writer.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/minidump_context_writer.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/minidump_misc_info_writer.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/cpu_architecture.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/cpu_context.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/cpu_context.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/cpu_context_linux.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/signal_context.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/test/test_cpu_context.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/snapshot/test/test_cpu_context.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/test/linux/get_tls.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/third_party/zlib/zlib.gyp
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/third_party/zlib/zlib_crashpad.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/linux/auxiliary_vector_test.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/linux/ptracer.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/linux/thread_info.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/misc/capture_context.h
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/misc/capture_context_linux.S
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/misc/capture_context_test.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/misc/capture_context_test_util_linux.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/posix/symbolic_constants_posix.cc
[modify] https://crrev.com/43e4c4dbdf088d47b7f838c075dc1f9b3b1af1cb/third_party/crashpad/crashpad/util/posix/symbolic_constants_posix_test.cc

Comment 6 by gordana....@mips.com, Sep 26 

This issue is fixed.

The record can be closed.
►

Sign in to add a comment