New issue
Advanced search Search tips

Issue 862724 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----


Participants' hotlists:
Slim-Nav-Burndown


Sign in to add a comment

ios_web_inttests fails with slim-navigation-manager

Project Member Reported by danyao@chromium.org, Jul 11

Issue description

HistoryStateOperationsTest.StateReplacementBackForward:
../../ios/web/navigation/history_state_operations_inttest.mm:364: Failure
Value of: IsOnLoadTextVisible()
  Actual: false
Expected: true
Stack trace:
0   ios_web_inttests                    0x000000010ef322fc base::debug::StackTrace::StackTrace() + 28
1   ios_web_inttests                    0x000000010ebba500 StackTraceGetter::CurrentStackTrace(int, int) + 64
2   ios_web_inttests                    0x000000010ebcb007 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71
3   ios_web_inttests                    0x000000010ebca44d testing::internal::AssertHelper::operator=(testing::Message const&) const + 125
4   ios_web_inttests                    0x000000010deed4ef HistoryStateOperationsTest_StateReplacementBackForward_Test::TestBody() + 6047
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32bdecc1fac228cf335811bea0f31e2a29153f29

commit 32bdecc1fac228cf335811bea0f31e2a29153f29
Author: Danyao Wang <danyao@chromium.org>
Date: Thu Jul 12 19:57:55 2018

[Nav Experiment] Parameterize HistoryStateOperationsTest.

So both LegacyNavigationManager and WKBasedNavigationManager can be
tested on trybots.

Fixed test expectation for StateReplacementBackForward to match the
behavior of WebKit (and Safari on other platforms).

Bug:  862724 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
Reviewed-on: https://chromium-review.googlesource.com/1134472
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574686}
[modify] https://crrev.com/32bdecc1fac228cf335811bea0f31e2a29153f29/ios/web/navigation/history_state_operations_inttest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment