New issue
Advanced search Search tips

Issue 862718 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: iOS
Pri: 2
Type: Task


Participants' hotlists:
Slim-Nav-Burndown


Sign in to add a comment

ios_web_unittests fail with slim-navigation-manager

Project Member Reported by danyao@chromium.org, Jul 11

Issue description

WebStateImplTest.ShowAndClearInterstitialWithCommittedItem
WebStateImplTest.ShowAndClearInterstitialWithoutChangingSslStatus
WebStateImplTest.ShowAndClearInterstitialWithNoCommittedItems

ScriptExecutionTest.UserScriptOnAppSpecificPage

CRWWebControllerTest.AbortNativeUrlNavigation
CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableEnabled
CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableDisabled


 
Labels: Proj-WKBackForwardList
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00ee7c4ed5ad09f68465f8e73c89639217adfacf

commit 00ee7c4ed5ad09f68465f8e73c89639217adfacf
Author: Danyao Wang <danyao@chromium.org>
Date: Wed Jul 11 22:19:19 2018

[Nav Experiment] Make WebStateImplTest parameterized.

This way both legacy and WK based navigation manager implementations are
tested on trybots.

Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
Disabled ShowAndClearInterstitialWithCommittedItem and
ShowAndClearInterstitialWithoutChangingSslStatus because they require
mocking out navigation state, which is not possible now.

Bug:  862718 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
Reviewed-on: https://chromium-review.googlesource.com/1134086
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574372}
[modify] https://crrev.com/00ee7c4ed5ad09f68465f8e73c89639217adfacf/ios/web/web_state/web_state_impl_unittest.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6a9497984526d151d178bfe8ec9dd1b1c84597c

commit d6a9497984526d151d178bfe8ec9dd1b1c84597c
Author: Danyao Wang <danyao@chromium.org>
Date: Wed Jul 11 22:53:56 2018

[Nav Experiment] Parameterize crw_web_controller_unittest.mm.

This is so that both LegacyNavigationManagerImpl and
WKBasedNavigationManagerImpl can be tested on trybots.

Also fixed broken test setup for
ScriptExecutionTest.UserScriptOnAppSpecificPage and
CRWWebControllerTest.AbortNativeUrlNavigation.

Bug:  862718 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
Reviewed-on: https://chromium-review.googlesource.com/1134406
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574390}
[modify] https://crrev.com/d6a9497984526d151d178bfe8ec9dd1b1c84597c/ios/web/web_state/ui/crw_web_controller_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment