mash: Crash in WindowDelegateImpl::GetCursor after click in omnibox |
||
Issue description1. chrome --enable-features=Mash 2. Window opens with new tab page 3. Click the "+" 4. Type "x" into omnibox ash process crashes Debugger shows infinite recursion in ui::ws2::WindowDelegateImpl::GetCursor() [244533:244533:0711/124552.164663:ERROR:window_delegate_impl.cc(37)] JAMES GetCursor on window RoundedOmniboxResultsFrameWindow [244533:244533:0711/124552.164697:ERROR:window_delegate_impl.cc(37)] JAMES GetCursor on window RoundedOmniboxResultsFrameWindow [244533:244533:0711/124552.164731:ERROR:window_delegate_impl.cc(37)] JAMES GetCursor on window RoundedOmniboxResultsFrameWindow [244533:244533:0711/124552.164765:ERROR:window_delegate_impl.cc(37)] JAMES GetCursor on window RoundedOmniboxResultsFrameWindow Something might be wrong with window parenting.
,
Jul 11
Forgot to tag the patch with the bug. This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1134352 . Will land a test shortly.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f340807ff46e1662b09c0cf4f73e788a0cbf946b commit f340807ff46e1662b09c0cf4f73e788a0cbf946b Author: Scott Violet <sky@chromium.org> Date: Thu Jul 12 00:26:10 2018 chromeos: test case for fixing infinite loop in cursor lookup BUG= 862715 TEST=none Change-Id: Ic5ac2f60ad310a0b9bb88e0f9430bbdbcc17397c Reviewed-on: https://chromium-review.googlesource.com/1134467 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574427} [modify] https://crrev.com/f340807ff46e1662b09c0cf4f73e788a0cbf946b/services/ui/ws2/BUILD.gn [add] https://crrev.com/f340807ff46e1662b09c0cf4f73e788a0cbf946b/services/ui/ws2/window_delegate_impl_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by jamescook@chromium.org
, Jul 11