ios_web_view_inttests is broken with slim-navigation-manager |
||||||
Issue description
[ RUN ] WebViewRestorableStateTest.EncodeDecode
[0711/073950.625202:WARNING:resource_bundle.cc(358)] locale_file_path.empty() for locale English
[0711/073950.655748:WARNING:resource_bundle.cc(576)] locale resources are not loaded
../../ios/web_view/test/web_view_restorable_state_inttest.mm:41: Failure
Expected equality of these values:
@"about:blank"
Which is: about:blank
[restored_web_view lastCommittedURL].absoluteString
Which is: (null)
Stack trace:
0 ios_web_view_inttests 0x000000010963bdcc base::debug::StackTrace::StackTrace() + 28
1 ios_web_view_inttests 0x0000000109473de0 StackTraceGetter::CurrentStackTrace(int, int) + 64
2 ios_web_view_inttests 0x00000001094880a7 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71
3 ios_web_view_inttests 0x00000001094874ed testing::internal::AssertHelper::operator=(testing::Message const&) const + 125
4 ios_web_view_inttests 0x000000010944b047 ios_web_view::WebViewRestorableStateTest_EncodeDecode_Test::TestBody() + 9655
../../ios/web_view/test/web_view_restorable_state_inttest.mm:42: Failure
Expected equality of these values:
@"about:blank"
Which is: about:blank
[restored_web_view visibleURL].absoluteString
Which is: about:newtab
Stack trace:
0 ios_web_view_inttests 0x000000010963bdcc base::debug::StackTrace::StackTrace() + 28
1 ios_web_view_inttests 0x0000000109473de0 StackTraceGetter::CurrentStackTrace(int, int) + 64
2 ios_web_view_inttests 0x00000001094880a7 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71
3 ios_web_view_inttests 0x00000001094874ed testing::internal::AssertHelper::operator=(testing::Message const&) const + 125
4 ios_web_view_inttests 0x000000010944b277 ios_web_view::WebViewRestorableStateTest_EncodeDecode_Test::TestBody() + 10215
[ FAILED ] WebViewRestorableStateTest.EncodeDecode (622 ms)
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e33b9da8d371a25857c422d277115441c629ce5 commit 8e33b9da8d371a25857c422d277115441c629ce5 Author: Danyao Wang <danyao@chromium.org> Date: Thu Jul 12 16:01:02 2018 Revert "[Nav Experiment] Add a wait after restore session." This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd. Reason for revert: This didn't actually fix the problem and I didn't catch it due to a mistake in testing. The real problem is that the restore_session request started in WKBasedNavigationManager::Restore() was not run, because |_containerView| is not yet initiated in the new CWVWebView. Original change's description: > [Nav Experiment] Add a wait after restore session. > > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is > enabled. A better approach would be to turn this test into a > programmatic test so both navigation managers implementations are > tested, but web::features symbols are not exposed in ios/web_view. > > Bug: 862714 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e > Reviewed-on: https://chromium-review.googlesource.com/1134046 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574367} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862714 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1135346 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#574577} [modify] https://crrev.com/8e33b9da8d371a25857c422d277115441c629ce5/ios/web_view/test/web_view_restorable_state_inttest.mm
,
Sep 12
,
Oct 23
,
Oct 23
,
Dec 10
Any update here? eugenebut: should this bug be reassigned?
,
Dec 10
Removed RBS label because slim nav is not going to M73. I have a fix ready (https://chromium-review.googlesource.com/c/chromium/src/+/1135435), but we can land it until we're ready to flip #slim-navigation-manager on in trunk. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 11