New issue
Advanced search Search tips

Issue 862712 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

filesystem_service_unittests should pass and run on android

Project Member Reported by thakis@chromium.org, Jul 11

Issue description

We ship filesystem_service code on Android. But when I tried to run the test binary there in https://chromium-review.googlesource.com/c/chromium/src/+/1132400/1 it didn't pass on Android:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/35820

FileImplTest.CantDoubleLock
DirectoryImplTest.WriteFileReadFile
DirectoryImplTest.Flush
DirectoryImplTest.Clone
FileImplTest.OpenInTruncateMode
DirectoryImplTest.ReadEmptyFileIsNotFoundError
DirectoryImplTest.Read
DirectoryImplTest.CantWriteFileOnADirectory
FileImplTest.Dup
FileImplTest.CreateWriteCloseRenameOpenRead
FileImplTest.SimpleLockUnlock
FileImplTest.Truncate
FileImplTest.AsHandle
FileImplTest.TellSeek
FileImplTest.ClosingFileClearsLock
DirectoryImplTest.BasicRenameDelete
FileImplTest.CantWriteInReadMode
FileImplTest.StatTouch
DirectoryImplTest.CantOpenDirectoriesAsFiles
DirectoryImplTest.CantReadEntireFileOnADirectory
FileImplTest.OpenInAppendMode


https://chromium-swarm.appspot.com/task?id=3e9fde6d9497db10&refresh=10



I   28.766s run_tests_on_device(023d6f79dead4023)  [ RUN      ] DirectoryImplTest.Read
I   28.766s run_tests_on_device(023d6f79dead4023)  [INFO:service_process_launcher.cc(202)] Launched child process pid=4639, instance=, name=filesystem, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84
I   28.766s run_tests_on_device(023d6f79dead4023)  ../../components/services/filesystem/files_test_base.cc:27: Failure
I   28.766s run_tests_on_device(023d6f79dead4023)  Value of: handled
I   28.766s run_tests_on_device(023d6f79dead4023)    Actual: false
I   28.766s run_tests_on_device(023d6f79dead4023)  Expected: true
I   28.766s run_tests_on_device(023d6f79dead4023)  Stack trace:
I   28.766s run_tests_on_device(023d6f79dead4023)  #00 0x0000007f91562b8b /data/app/org.chromium.native_test-1/lib/arm64/lib_filesystem_service_unittests__library.so+0x000000000013fb8b
I   28.766s run_tests_on_device(023d6f79dead4023)  #01 0x0000007f915501d3 /data/app/org.chromium.native_test-1/lib/arm64/lib_filesystem_service_unittests__library.so+0x000000000012d1d3
I   28.766s run_tests_on_device(023d6f79dead4023)  #02 0x0000007f91591fa3 /data/app/org.chromium.native_test-1/lib/arm64/lib_filesystem_service_unittests__library.so+0x000000000016efa3
I   28.766s run_tests_on_device(023d6f79dead4023)  
I   28.766s run_tests_on_device(023d6f79dead4023)  ../../components/services/filesystem/directory_impl_unittest.cc:38: Failure
I   28.766s run_tests_on_device(023d6f79dead4023)  Value of: handled
I   28.766s run_tests_on_device(023d6f79dead4023)    Actual: false
I   28.766s run_tests_on_device(023d6f79dead4023)  Expected: true
I   28.766s run_tests_on_device(023d6f79dead4023)  Stack trace:
I   28.766s run_tests_on_device(023d6f79dead4023)  #00 0x0000007f9155042b /data/app/org.chromium.native_test-1/lib/arm64/lib_filesystem_service_unittests__library.so+0x000000000012d42b
I   28.766s run_tests_on_device(023d6f79dead4023)  #01 0x0000007f91591fa3 /data/app/org.chromium.native_test-1/lib/arm64/lib_filesystem_service_unittests__library.so+0x000000000016efa3
I   28.767s run_tests_on_device(023d6f79dead4023)  
I   28.767s run_tests_on_device(023d6f79dead4023)  [  FAILED  ] DirectoryImplTest.Read (46 ms)


The other test failures look similar as far as I can tell.
 
Cc: blundell@chromium.org
Cc: roc...@chromium.org mek@chromium.org
Components: -Blink>Storage>FileSystem
I don't think there is anything filesystem specific going on here, afaict this is just making sure that service_test() works on android? So removing FileSystem component for now, feel free to add it back if I'm wrong.
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment