New issue
Advanced search Search tips

Issue 862696 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
DFM

Blocking:
issue 850674
issue 862694



Sign in to add a comment

Add synchronized proguarding

Project Member Reported by tiborg@chromium.org, Jul 11

Issue description

See go/gn-aab-proguarding for details
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01020f3bca281b6de9bd9deacbe849cbc1255cfa

commit 01020f3bca281b6de9bd9deacbe849cbc1255cfa
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Jul 12 20:29:21 2018

Android: Do not generate R.java from android_apk AndroidManifest.xml

In order to implement synchronized proguarding we cannot have multiple
R class with the same package. Thus, prevent creation of R files with
manifest's package when creating APKs.

Bug:  862696 
Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c
Reviewed-on: https://chromium-review.googlesource.com/1134414
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574703}
[modify] https://crrev.com/01020f3bca281b6de9bd9deacbe849cbc1255cfa/build/android/gyp/compile_resources.py
[modify] https://crrev.com/01020f3bca281b6de9bd9deacbe849cbc1255cfa/build/android/gyp/util/resource_utils.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af230902dc50673782e6789dd87775a3c8a8b1ee

commit af230902dc50673782e6789dd87775a3c8a8b1ee
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Jul 20 22:15:18 2018

[aab] Make base module targets

This prepares for synchronized proguarding and allows us to configure
the base modules differently than the Chrome APKs.

+ Stop making an APK if building a module.

Bug:  862696 
Change-Id: I28b245888241e3519454c8957fcf0e460925f459
Reviewed-on: https://chromium-review.googlesource.com/1138870
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577012}
[modify] https://crrev.com/af230902dc50673782e6789dd87775a3c8a8b1ee/build/config/android/internal_rules.gni
[modify] https://crrev.com/af230902dc50673782e6789dd87775a3c8a8b1ee/build/config/android/rules.gni
[modify] https://crrev.com/af230902dc50673782e6789dd87775a3c8a8b1ee/chrome/android/BUILD.gn
[modify] https://crrev.com/af230902dc50673782e6789dd87775a3c8a8b1ee/chrome/android/chrome_public_apk_tmpl.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028b3b681d9c76397ed422f6b37ade8b0abb3353

commit 028b3b681d9c76397ed422f6b37ade8b0abb3353
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Jul 23 22:34:15 2018

[aab] Add build_config for Android App Bundles

Also, add android_app_bundle_module type to build config.

Bug:  862696 
Change-Id: Ic893f47d44d8dd98ff7e70d3a8e09cbf2ce5a444
Reviewed-on: https://chromium-review.googlesource.com/1135834
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577305}
[modify] https://crrev.com/028b3b681d9c76397ed422f6b37ade8b0abb3353/build/android/gyp/write_build_config.py
[modify] https://crrev.com/028b3b681d9c76397ed422f6b37ade8b0abb3353/build/config/android/internal_rules.gni
[modify] https://crrev.com/028b3b681d9c76397ed422f6b37ade8b0abb3353/build/config/android/rules.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bbde2a8f25943e648e568d3e208d28926481e0e

commit 4bbde2a8f25943e648e568d3e208d28926481e0e
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Jul 30 22:45:59 2018

[aab] Add synchronized proguarding

This means that the compiled Java of each DFM and the base module are optimized
together in one proguarding step. The advantage is that symbols and symbol
usages get obfuscated in the same way and, thus, usages still work even in the
optimized state. To allow modularization, we split the optimized Jar into the
modules after.

Design doc: go/gn-aab-proguarding

Bug:  862696 
Change-Id: I0f6032b09b31a572838721e0b90b025ff879891d
Reviewed-on: https://chromium-review.googlesource.com/1149040
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579210}
[add] https://crrev.com/4bbde2a8f25943e648e568d3e208d28926481e0e/build/android/gyp/generate_proguarded_module_jar.py
[modify] https://crrev.com/4bbde2a8f25943e648e568d3e208d28926481e0e/build/android/gyp/write_build_config.py
[modify] https://crrev.com/4bbde2a8f25943e648e568d3e208d28926481e0e/build/config/android/internal_rules.gni
[modify] https://crrev.com/4bbde2a8f25943e648e568d3e208d28926481e0e/build/config/android/rules.gni
[modify] https://crrev.com/4bbde2a8f25943e648e568d3e208d28926481e0e/chrome/android/BUILD.gn

Status: Fixed (was: Started)
Labels: DFM

Sign in to add a comment