Create a GN target for a VR java library (essentially containing the classes from chrome_vr_java_sources) and GN target for the VR DFM APK.
Bumping to M71 as discussed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f86a758d7984ab71181a0102fe72a7ac538a1a52 commit f86a758d7984ab71181a0102fe72a7ac538a1a52 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Aug 08 15:53:11 2018 [vr] Make VR Java android_library and separate VR JNI registration This CL does two things: - In order to move VR Java code into its own module move the code into a separate android_library target. - As a result of the separate library target we may miss making the VR JNI registrations (in case VR moves out of chrome_public_apk). Thus, separate the JNI registration generation for VR and register VR JNI calls in VR code. Bug: 862694 Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 Reviewed-on: https://chromium-review.googlesource.com/1158715 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#581576} [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/base/android/jni_generator/jni_exception_list.gni [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/base/android/jni_generator/jni_generator_tests.py [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/base/android/jni_generator/jni_registration_generator.py [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/base/android/jni_generator/testInnerClassNativesBothInnerAndOuterRegistrations.golden [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/base/android/jni_generator/testNativesRegistrations.golden [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/build/android/gyp/proguard.py [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/build/android/gyp/write_build_config.py [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/build/config/android/rules.gni [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/android/BUILD.gn [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/android/java_sources.gni [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/browser/android/vr/BUILD.gn [add] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/browser/android/vr/register_jni.cc [add] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/browser/android/vr/register_jni.h [add] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/browser/android/vr/register_jni_monochrome.cc [add] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/browser/android/vr/vr_module_provider.cc [modify] https://crrev.com/f86a758d7984ab71181a0102fe72a7ac538a1a52/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aee1497513cadbdb538d0a53db6ae8cd96337657 commit aee1497513cadbdb538d0a53db6ae8cd96337657 Author: Ted Choc <tedchoc@chromium.org> Date: Wed Aug 08 21:08:18 2018 Revert "[vr] Make VR Java android_library and separate VR JNI registration" This reverts commit f86a758d7984ab71181a0102fe72a7ac538a1a52. Reason for revert: Breaks x86 bots https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/28950 Original change's description: > [vr] Make VR Java android_library and separate VR JNI registration > > This CL does two things: > > - In order to move VR Java code into its own module move the code into a > separate android_library target. > > - As a result of the separate library target we may miss making the VR > JNI registrations (in case VR moves out of chrome_public_apk). Thus, > separate the JNI registration generation for VR and register VR JNI > calls in VR code. > > Bug: 862694 > Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 > Reviewed-on: https://chromium-review.googlesource.com/1158715 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581576} TBR=mthiesse@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: Iccac3c8981c21fe105799e045f1629dbd99fb7c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862694 Reviewed-on: https://chromium-review.googlesource.com/1168043 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581692} [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/base/android/jni_generator/jni_exception_list.gni [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/base/android/jni_generator/jni_generator_tests.py [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/base/android/jni_generator/jni_registration_generator.py [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/base/android/jni_generator/testInnerClassNativesBothInnerAndOuterRegistrations.golden [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/base/android/jni_generator/testNativesRegistrations.golden [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/build/android/gyp/proguard.py [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/build/android/gyp/write_build_config.py [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/build/config/android/rules.gni [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/android/BUILD.gn [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/android/java_sources.gni [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/browser/android/vr/BUILD.gn [delete] https://crrev.com/e21a714a52962d539569068a8522dd8ed1804b2b/chrome/browser/android/vr/register_jni.cc [delete] https://crrev.com/e21a714a52962d539569068a8522dd8ed1804b2b/chrome/browser/android/vr/register_jni.h [delete] https://crrev.com/e21a714a52962d539569068a8522dd8ed1804b2b/chrome/browser/android/vr/register_jni_monochrome.cc [delete] https://crrev.com/e21a714a52962d539569068a8522dd8ed1804b2b/chrome/browser/android/vr/vr_module_provider.cc [modify] https://crrev.com/aee1497513cadbdb538d0a53db6ae8cd96337657/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ee8761e1515212802af23041e32fd2b2cefc0eb commit 5ee8761e1515212802af23041e32fd2b2cefc0eb Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Aug 10 18:48:54 2018 Reland "[vr] Make VR Java android_library and separate VR JNI registration" This is a reland of f86a758d7984ab71181a0102fe72a7ac538a1a52 with fix for x86 bots that have VR disabled. Original change's description: > [vr] Make VR Java android_library and separate VR JNI registration > > This CL does two things: > > - In order to move VR Java code into its own module move the code into a > separate android_library target. > > - As a result of the separate library target we may miss making the VR > JNI registrations (in case VR moves out of chrome_public_apk). Thus, > separate the JNI registration generation for VR and register VR JNI > calls in VR code. > > Bug: 862694 > Change-Id: I2b78cea7b30725d5f2b51afbcac1a6add555f355 > Reviewed-on: https://chromium-review.googlesource.com/1158715 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581576} TBR=agrieve@chromium.org,mthiesse@chromium.org Bug: 862694 Change-Id: If069e04fe7897f95ce7634b5fd6199eece3a6f73 Reviewed-on: https://chromium-review.googlesource.com/1167770 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582269} [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/base/android/jni_generator/jni_exception_list.gni [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/base/android/jni_generator/jni_generator_tests.py [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/base/android/jni_generator/jni_registration_generator.py [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/base/android/jni_generator/testInnerClassNativesBothInnerAndOuterRegistrations.golden [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/base/android/jni_generator/testNativesRegistrations.golden [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/build/android/gyp/proguard.py [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/build/android/gyp/write_build_config.py [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/build/config/android/rules.gni [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/BUILD.gn [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/chrome_public_apk_tmpl.gni [add] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/android/java_sources.gni [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/browser/android/vr/BUILD.gn [add] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/browser/android/vr/register_jni.cc [add] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/browser/android/vr/register_jni.h [add] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/browser/android/vr/register_jni_monochrome.cc [add] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/browser/android/vr/vr_module_provider.cc [modify] https://crrev.com/5ee8761e1515212802af23041e32fd2b2cefc0eb/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99aaaedd7636753da3198fef737a68928e54c4a0 commit 99aaaedd7636753da3198fef737a68928e54c4a0 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Aug 17 15:10:24 2018 [build:android] Add a module for VR in Chrome Modern Bug: 862694 Change-Id: I4ab7cb60c8e397964f88449c31ff4fd0d6f4e253 Reviewed-on: https://chromium-review.googlesource.com/1173252 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584070} [modify] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/BUILD.gn [modify] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/chrome_public_apk_tmpl.gni [add] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/modules/vr/AndroidManifest.xml [add] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/modules/vr/OWNERS [add] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/modules/vr/README [add] https://crrev.com/99aaaedd7636753da3198fef737a68928e54c4a0/chrome/android/modules/vr/vr_module_tmpl.gni
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/54b7f8b682e9f52dae8f9a5215c94d8b504b6c00 commit 54b7f8b682e9f52dae8f9a5215c94d8b504b6c00 Author: Tibor Goldschwendt <tiborg@google.com> Date: Wed Aug 22 21:21:25 2018
Comment 1 by tiborg@chromium.org
, Jul 11