VR DFM: on-demand install VR DFM |
||||||||||||
Issue descriptionSee go/chromevr-java-dfm#heading=h.x3ss9yf862af for more details.
,
Jul 11
,
Aug 7
Bumping to M71 as discussed.
,
Aug 24
Bundletool requires on-demand modules to reference a base module string for their module title in the manifest. Blocking on that now.
,
Sep 24
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9930f79521db12e560b0a818d996f3065cf5af7c commit 9930f79521db12e560b0a818d996f3065cf5af7c Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Sep 26 18:29:22 2018 [vr] Add strings required for VR module on-demand install Bug: 862689 Change-Id: If9713d4a079965047df35a8f5a4e93adf7e390bf Reviewed-on: https://chromium-review.googlesource.com/1246299 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594398} [modify] https://crrev.com/9930f79521db12e560b0a818d996f3065cf5af7c/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/9930f79521db12e560b0a818d996f3065cf5af7c/chrome/android/java/strings/android_chrome_strings.grd
,
Oct 24
Increasing priority since this bug is blocking bundle release.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0275d36033c0a24af4c67ec8eb1a71cb84adb347 commit 0275d36033c0a24af4c67ec8eb1a71cb84adb347 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Oct 25 23:28:08 2018 [vr] On-demand install VR dynamic feature module With this CL we initate the module install once the user enters VR on a WebXR/VR page. In more detail this CL - Introduces native VrModuleDelegate used to request VR module from native, - Refactors GvrDevice to request the VR module as part of its initialization flow, - Adds native side of the VrModuleProvider for Java-native communication. Bug: 862689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b Reviewed-on: https://chromium-review.googlesource.com/c/1241458 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602922} [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/browser/android/vr/vr_module_provider.cc [add] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/device/vr/BUILD.gn [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/device/vr/android/gvr/gvr_device.h [add] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/device/vr/android/gvr/vr_module_delegate.cc [add] https://crrev.com/0275d36033c0a24af4c67ec8eb1a71cb84adb347/device/vr/android/gvr/vr_module_delegate.h
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a507f48b6263d10e799402aea43d3262a505ca3e commit a507f48b6263d10e799402aea43d3262a505ca3e Author: Takashi Sakamoto <tasak@google.com> Date: Fri Oct 26 06:33:46 2018 Revert "[vr] On-demand install VR dynamic feature module" This reverts commit 0275d36033c0a24af4c67ec8eb1a71cb84adb347. Reason for revert: Suspect compile failure on Android(x64) Builder Dbg. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/30291 Log: ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:114: error: cannot find symbol Toast.makeText(ContextUtils.getApplicationContext(), R.string.vr_module_install_start_text, ^ symbol: variable vr_module_install_start_text location: class string ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:127: error: cannot find symbol int mToastTextRes = success ? R.string.vr_module_install_success_text ^ symbol: variable vr_module_install_success_text location: class string ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:128: error: cannot find symbol : R.string.vr_module_install_failure_text; ^ symbol: variable vr_module_install_failure_text location: class string 3 errors Original change's description: > [vr] On-demand install VR dynamic feature module > > With this CL we initate the module install once the user enters VR on a > WebXR/VR page. In more detail this CL > > - Introduces native VrModuleDelegate used to request VR module from > native, > > - Refactors GvrDevice to request the VR module as part of its > initialization flow, > > - Adds native side of the VrModuleProvider for Java-native > communication. > > Bug: 862689 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602922} TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org Change-Id: I19d05dd6f13e5d6eee5ea0ac2f168a3a4d1a3680 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1301194 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#603007} [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/chrome/browser/android/vr/vr_module_provider.cc [delete] https://crrev.com/3b3ec56acbbd297c668543de6ecbde27d07f8942/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/device/vr/BUILD.gn [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/a507f48b6263d10e799402aea43d3262a505ca3e/device/vr/android/gvr/gvr_device.h [delete] https://crrev.com/3b3ec56acbbd297c668543de6ecbde27d07f8942/device/vr/android/gvr/vr_module_delegate.cc [delete] https://crrev.com/3b3ec56acbbd297c668543de6ecbde27d07f8942/device/vr/android/gvr/vr_module_delegate.h
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d86401200bd7fbc0c4e60867e437842abcbc1e9 commit 6d86401200bd7fbc0c4e60867e437842abcbc1e9 Author: Takashi Sakamoto <tasak@google.com> Date: Fri Oct 26 13:10:32 2018 Revert "[vr] On-demand install VR dynamic feature module" This reverts commit 0275d36033c0a24af4c67ec8eb1a71cb84adb347. Reason for revert: Suspect compile failure on Android(x64) Builder Dbg. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/30291 Log: ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:114: error: cannot find symbol Toast.makeText(ContextUtils.getApplicationContext(), R.string.vr_module_install_start_text, ^ symbol: variable vr_module_install_start_text location: class string ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:127: error: cannot find symbol int mToastTextRes = success ? R.string.vr_module_install_success_text ^ symbol: variable vr_module_install_success_text location: class string ../../chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java:128: error: cannot find symbol : R.string.vr_module_install_failure_text; ^ symbol: variable vr_module_install_failure_text location: class string 3 errors Original change's description: > [vr] On-demand install VR dynamic feature module > > With this CL we initate the module install once the user enters VR on a > WebXR/VR page. In more detail this CL > > - Introduces native VrModuleDelegate used to request VR module from > native, > > - Refactors GvrDevice to request the VR module as part of its > initialization flow, > > - Adds native side of the VrModuleProvider for Java-native > communication. > > Bug: 862689 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602922} TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org Change-Id: I19d05dd6f13e5d6eee5ea0ac2f168a3a4d1a3680 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1301194 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Original-Commit-Position: refs/heads/master@{#603007}(cherry picked from commit a507f48b6263d10e799402aea43d3262a505ca3e) Reviewed-on: https://chromium-review.googlesource.com/c/1301561 Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/3592@{#3} Cr-Branched-From: 987c04d3d73e1f006fabab2d683994ed3170b4c7-refs/heads/master@{#602946} [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/chrome/browser/android/vr/vr_module_provider.cc [delete] https://crrev.com/ea1776d52991be392ca47a60efa3a9d024ca5862/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/device/vr/BUILD.gn [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/6d86401200bd7fbc0c4e60867e437842abcbc1e9/device/vr/android/gvr/gvr_device.h [delete] https://crrev.com/ea1776d52991be392ca47a60efa3a9d024ca5862/device/vr/android/gvr/vr_module_delegate.cc [delete] https://crrev.com/ea1776d52991be392ca47a60efa3a9d024ca5862/device/vr/android/gvr/vr_module_delegate.h
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a8ce56213d8bba7a870171ab69bb6b28e84bca4 commit 0a8ce56213d8bba7a870171ab69bb6b28e84bca4 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Oct 26 15:21:16 2018 Reland "[vr] On-demand install VR dynamic feature module" This is a reland of 0275d36033c0a24af4c67ec8eb1a71cb84adb347 with a fix for x86 builders, which have VR disabled. Original change's description: > [vr] On-demand install VR dynamic feature module > > With this CL we initate the module install once the user enters VR on a > WebXR/VR page. In more detail this CL > > - Introduces native VrModuleDelegate used to request VR module from > native, > > - Refactors GvrDevice to request the VR module as part of its > initialization flow, > > - Adds native side of the VrModuleProvider for Java-native > communication. > > Bug: 862689 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602922} TBR=tedchoc@chromium.org,billorr@chromium.org Bug: 862689 Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1301568 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603100} [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/browser/android/vr/vr_module_provider.cc [add] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/device/vr/BUILD.gn [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/device/vr/android/gvr/gvr_device.h [add] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/device/vr/android/gvr/vr_module_delegate.cc [add] https://crrev.com/0a8ce56213d8bba7a870171ab69bb6b28e84bca4/device/vr/android/gvr/vr_module_delegate.h
,
Oct 26
Hopefully fixed now.
,
Oct 29
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f66e2d00837468c68af18784cd4f12fa8c40542d commit f66e2d00837468c68af18784cd4f12fa8c40542d Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Oct 29 17:36:52 2018 Revert "Reland "[vr] On-demand install VR dynamic feature module"" This reverts commit 0a8ce56213d8bba7a870171ab69bb6b28e84bca4. Reason for revert: crbug/899732 Original change's description: > Reland "[vr] On-demand install VR dynamic feature module" > > This is a reland of 0275d36033c0a24af4c67ec8eb1a71cb84adb347 with a fix > for x86 builders, which have VR disabled. > > Original change's description: > > [vr] On-demand install VR dynamic feature module > > > > With this CL we initate the module install once the user enters VR on a > > WebXR/VR page. In more detail this CL > > > > - Introduces native VrModuleDelegate used to request VR module from > > native, > > > > - Refactors GvrDevice to request the VR module as part of its > > initialization flow, > > > > - Adds native side of the VrModuleProvider for Java-native > > communication. > > > > Bug: 862689 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602922} > > TBR=tedchoc@chromium.org,billorr@chromium.org > > Bug: 862689 > Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1301568 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603100} TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862689 , 899732 Change-Id: I89de56edc6c300955534a701deb92178cf50683e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1305093 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603545} [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/chrome/browser/android/vr/vr_module_provider.cc [delete] https://crrev.com/37618e142085331a792b83bdc14fcc07176f5e93/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/device/vr/BUILD.gn [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/f66e2d00837468c68af18784cd4f12fa8c40542d/device/vr/android/gvr/gvr_device.h [delete] https://crrev.com/37618e142085331a792b83bdc14fcc07176f5e93/device/vr/android/gvr/vr_module_delegate.cc [delete] https://crrev.com/37618e142085331a792b83bdc14fcc07176f5e93/device/vr/android/gvr/vr_module_delegate.h
,
Oct 29
Still problems...
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65bebe500fac1cacf56d762592b2b1b90be652fb commit 65bebe500fac1cacf56d762592b2b1b90be652fb Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Oct 30 15:31:54 2018 Reland "Reland "[vr] On-demand install VR dynamic feature module"" This is a reland of 0a8ce56213d8bba7a870171ab69bb6b28e84bca4 with a fix for x86 crashes (see crbug/899732 for more details). Original change's description: > Reland "[vr] On-demand install VR dynamic feature module" > > This is a reland of 0275d36033c0a24af4c67ec8eb1a71cb84adb347 with a fix > for x86 builders, which have VR disabled. > > Original change's description: > > [vr] On-demand install VR dynamic feature module > > > > With this CL we initate the module install once the user enters VR on a > > WebXR/VR page. In more detail this CL > > > > - Introduces native VrModuleDelegate used to request VR module from > > native, > > > > - Refactors GvrDevice to request the VR module as part of its > > initialization flow, > > > > - Adds native side of the VrModuleProvider for Java-native > > communication. > > > > Bug: 862689 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602922} > > TBR=tedchoc@chromium.org,billorr@chromium.org > > Bug: 862689 > Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1301568 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603100} TBR=tedchoc@chromium.org,billorr@chromium.org Bug: 862689 ,899732 Change-Id: I944f97d82d04f3dc64f44a3379551f09ca1326f3 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1305816 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603905} [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/BUILD.gn [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java [add] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/java/src/org/chromium/chrome/browser/vr/VrBuildConfig.template [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/android/modules/vr/AndroidManifest.xml [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/browser/android/vr/vr_module_provider.cc [add] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/chrome/browser/android/vr/vr_module_provider.h [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/device/vr/BUILD.gn [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/device/vr/android/gvr/gvr_device.h [add] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/device/vr/android/gvr/vr_module_delegate.cc [add] https://crrev.com/65bebe500fac1cacf56d762592b2b1b90be652fb/device/vr/android/gvr/vr_module_delegate.h
,
Oct 30
Fixed III
,
Jan 3
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tiborg@chromium.org
, Jul 11