New issue
Advanced search Search tips

Issue 862681 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
DFM

Blocking:
issue 850674
issue 862707
issue 863068
issue 862689
issue 862690
issue 863064



Sign in to add a comment

On-demand DFMs: Add Play Core SDK to //src/third_party/

Project Member Reported by tiborg@chromium.org, Jul 11

Issue description

For on-demand modules, such as the VR and AR DFM, need the Play Core SDK to request the modules. Add this library to third_party.

Play Core SDK: https://developer.android.com/reference/com/google/android/play/core/packages
Maven repo: https://mvnrepository.com/artifact/com.google.android.play/core/1.2.0
 
Blocking: 862689
Blocking: 862690
Summary: On-demand DFMs: Add Play Core SDK to //src/third_party/ (was: DFMs: Add Play Core SDK to //src/third_party/)
Blocking: 862707
Blocking: 863068
Components: -Internals>XR>VR
Blocking: 863064
Owner: tiborg@chromium.org
Status: Started (was: Available)
Labels: -Target-70 Target-71
Bumping to M71 as discussed.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2696eb8ff66d1e83a77e505a9ed44b18acef5422

commit 2696eb8ff66d1e83a77e505a9ed44b18acef5422
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Aug 07 21:42:18 2018

[aab] Add Google Android Play Core to //third_party/android_deps

This library is needed to on-demand install dynamic feature modules.

Bug:  862681 
Change-Id: I6d4f76e614c464bdbd4fb3be7c69d1a583a75f1b
Reviewed-on: https://chromium-review.googlesource.com/1151531
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581345}
[modify] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/DEPS
[modify] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/BUILD.gn
[modify] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/additional_readme_paths.json
[add] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/libs/com_google_android_play_core/OWNERS
[add] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/libs/com_google_android_play_core/README.chromium
[add] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/libs/com_google_android_play_core/cipd.yaml
[add] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/third_party/android_deps/libs/com_google_android_play_core/com_google_android_play_core.info
[modify] https://crrev.com/2696eb8ff66d1e83a77e505a9ed44b18acef5422/tools/android/roll/android_deps/build.gradle

Status: Fixed (was: Started)
Labels: DFM

Sign in to add a comment