Diff filtering: Pylint comments (with no end line) are being filtered out |
||
Issue descriptionExample CL: https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1096122/15 Example log excerpt: Num changed lines for example.py is 26. Filtering out comment on lines 19-0. Num changed lines for example.py is 26. Filtering out comment on lines 6-0. Num changed lines for example.py is 26. Filtering out comment on lines 16-0. Hypothesis: line filtering doesn't work when comment has no end line. Proposed fix: I think we want endLine == 0 to represent a single-line comment. End line should be optional.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3b3b5380c9eeeae0128da7118845277664f753ed commit 3b3b5380c9eeeae0128da7118845277664f753ed Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Jul 12 18:29:24 2018 [tricium] Allow end line == 0 when filtering comments Bug: 862650 Change-Id: If1fdbbe043285abb0afe9644754902205fa92294 Reviewed-on: https://chromium-review.googlesource.com/1133689 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/3b3b5380c9eeeae0128da7118845277664f753ed/go/src/infra/tricium/appengine/gerrit/rpc_report_results.go [modify] https://crrev.com/3b3b5380c9eeeae0128da7118845277664f753ed/go/src/infra/tricium/appengine/gerrit/rpc_report_results_test.go
,
Jul 16
|
||
►
Sign in to add a comment |
||
Comment 1 by qyearsley@google.com
, Jul 11