New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862643 link

Starred by 1 user
Status: Duplicate
Merged: issue 855042
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Closed: Jul 11
Cc:
falken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug

Blocked on:
issue 855042


Sign in to add a comment

Recent move of UseCounter introduced test failure with network servicification

Project Member Reported by cmumford@chromium.org, Jul 11 
The recent move of UseCounter from Page to DocumentLoader is causing the following Blink layout test to fail:

  http/tests/serviceworker/navigation_preload/use-counter.html

when using the network service. To reproduce run the blink layout tests with:

  --additional-driver-flag=--enable-features=NetworkService

The portion that is failing is the third test in the above file with the following scope "resources/dummy?passthrough".

Comment 1 by cmumford@chromium.org, Jul 11 

The change that introduced this failure appears to be https://chromium-review.googlesource.com/c/chromium/src/+/1079787

Comment 2 by loonyb...@chromium.org, Jul 11

Blockedon: 855042
Cc: falken@chromium.org
Thanks for the finding. 

Yes, because the test is wrong. I will override the test expect for now. I believe falken is working on fixing the tests.

Comment 3 by cmumford@chromium.org, Jul 11 

I'm temporarily disabling this in http://crrev.com/c/1133685. If you change the test expect can you re-enable that assert?

Comment 4 by loonyb...@chromium.org, Jul 11

Blockedon: -855042
Mergedinto: 855042
Status: Duplicate (was: Assigned)
I think disabling it is good enough. Merging it to the other issue.

Comment 5 by loonyb...@chromium.org, Jul 11

Blockedon: 855042
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca700a51e4bea95516073239ceb682c0586ba96c

commit ca700a51e4bea95516073239ceb682c0586ba96c
Author: Chris Mumford <cmumford@chromium.org>
Date: Wed Jul 11 19:33:50 2018

Disable portion of navigation preload test failing with network service.

A recent change (crrev.com/c/1079787) is causing
a portion of http/tests/serviceworker/navigation_preload/use-counter.html
to fail when the network service is disabled. Temporarily disabling.

TBR=loonybear@chromium.org,jam@chromium.org

Bug:  862643 
Change-Id: I32848d107bfd7aabdf7de71fc177aebcce386d2a
Reviewed-on: https://chromium-review.googlesource.com/1133685
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574286}
[modify] https://crrev.com/ca700a51e4bea95516073239ceb682c0586ba96c/third_party/WebKit/LayoutTests/TestExpectations
►

Sign in to add a comment