Add IPH for bottom toolbar |
|||||||||
Issue descriptionWe should add in-product-help to notify the user that their icons have been moved to the bottom of the screen. Something as simple as "Your icons have moved to the bottom." should work.
,
Jul 16
,
Aug 1
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2 commit a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Aug 02 18:27:25 2018 Add one-time IPH for bottom toolbar This patch adds one-time IPH for the bottom toolbar for the first time that it is enabled. The help bubble appears under the bottom toolbar and states that the icons have moved to the bottom of the screen. Bug: 862611 Change-Id: I597401a1030cc9f0c4ea3537bcf9a597b8d28275 Reviewed-on: https://chromium-review.googlesource.com/1138729 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580255} [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/feature_constants.cc [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/feature_constants.h [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/feature_list.cc [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/components/feature_engagement/public/feature_list.h [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/tools/metrics/actions/actions.xml [modify] https://crrev.com/a7d9ba3b289a917c1b61e3982a8ae41e061e1bf2/tools/metrics/histograms/histograms.xml
,
Aug 2
The primary IPH we want for experimentation has landed. We can file other tasks for more IPH if we find it necessary later.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/882f5922e39a88fc7925761f4c773abfc2aa3bb4 commit 882f5922e39a88fc7925761f4c773abfc2aa3bb4 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Sep 05 17:13:00 2018 Update Duet IPH to work well on NTP This patch updates Duet's IPH to work on the NTP which has no visible toolbar (which the bubble whould ordinarily anchor to). Instead, the bubble takes the place of the toolbar and removes the arrow. Bug: 862611 Change-Id: I523d8d14748ff2668101ec1890e36decd5c07213 Reviewed-on: https://chromium-review.googlesource.com/1207311 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588905} [modify] https://crrev.com/882f5922e39a88fc7925761f4c773abfc2aa3bb4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
,
Sep 11
,
Sep 11
This bug requires manual review: There is .grd file changes and we are only 34 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11
@#10, the patch being suggested for merge is #8 which does not have any string changes.
,
Sep 11
Approved for merge into 70, branch 3538.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a40a87178174a34f5b7d38874ec90f7cdf56db commit 40a40a87178174a34f5b7d38874ec90f7cdf56db Author: Matthew Jones <mdjones@chromium.org> Date: Tue Sep 11 21:58:03 2018 Update Duet IPH to work well on NTP This patch updates Duet's IPH to work on the NTP which has no visible toolbar (which the bubble whould ordinarily anchor to). Instead, the bubble takes the place of the toolbar and removes the arrow. TBR=mdjones@chromium.org (cherry picked from commit 882f5922e39a88fc7925761f4c773abfc2aa3bb4) Bug: 862611 Change-Id: I523d8d14748ff2668101ec1890e36decd5c07213 Reviewed-on: https://chromium-review.googlesource.com/1207311 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588905} Reviewed-on: https://chromium-review.googlesource.com/1220575 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#299} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/40a40a87178174a34f5b7d38874ec90f7cdf56db/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
,
Sep 12
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mdjones@chromium.org
, Jul 11