New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862608 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Aug 10
Cc:
cduvall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Proj-Servicification

Blocked on:
issue 866635
issue 868220
Blocking:
issue 721401



Sign in to add a comment

Switch google_apis/gcm/engine/connection_factory_impl.cc to network service's proxy_resolving_socket.mojom

Project Member Reported by xunji...@chromium.org, Jul 11 
google_apis/gcm/engine/connection_factory_impl.cc uses net::ProxyResolvingClientSocket. 
Now the equivalent mojo interfaces are available (//services/network/public/mojom/proxy_resolving_socket.mojom), we need to switch gcm to using those instead of calling into URLRequestContext.

Comment 1 by xunji...@chromium.org, Jul 11

Owner: xunji...@chromium.org
Status: Started (was: Available)

Comment 2 by dxie@chromium.org, Jul 12

Labels: OS-Windows

Comment 3 by xunji...@chromium.org, Jul 24

Blockedon: 866635
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365f6904890e5ee7e90f55189ab5d95b80bc3dbe

commit 365f6904890e5ee7e90f55189ab5d95b80bc3dbe
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Jul 26 18:53:15 2018

Migrate gcm to network service's socket APIs

With network service, net:: C++ socket access will need to be changed to using
network service's socket APIs. This CL changes gcm to using
proxy_resolving_socket.mojom instead of the C++ ProxyResolvingClientSocket.

GCM files that are changed:
- google_apis/gcm/engine/connection_factory_impl.cc
  This will request and own a network::mojom::ProxyResolvingSocketPtr
- google_apis/gcm/engine/connection_handler_impl.cc
  This will pass the mojo read/write pipes to socket streams.
- google_apis/gcm/base/socket_stream.cc
  SocketInputStream/SocketOutputStream will read from/write to mojo data pipes
  instead of the C++ socket.

Network service changes
- services/network/public/mojom/proxy_resolving_socket.mojom
  Peer address is surfaced directly when connection is established. This is
  needed to support GCM's use case. They need the peer address synchronously
  when connection is done.

Browser changes:
- NetworkContext raw mojo pointer has to be queried on the UI thread on demand.
  Therefore changes are added to pass through a callback and ui task runner.

Bug:  862608 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic0c72c8ee7d9bc7deb6e8109234227f80ea3bbe3
Reviewed-on: https://chromium-review.googlesource.com/1142344
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578386}
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/DEPS
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/fake_gcm_client.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/fake_gcm_client.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_client.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_client_impl.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_desktop_utils.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_driver_desktop.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_driver_desktop_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/components/gcm_driver/instance_id/BUILD.gn
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/DEPS
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/base/socket_stream.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/base/socket_stream.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_factory.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_factory_impl_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_handler.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_handler_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_handler_impl.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/fake_connection_factory.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/fake_connection_handler.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/engine/fake_connection_handler.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/google_apis/gcm/tools/mcs_probe.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/ios/web/browser_state.mm
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/ios/web/public/browser_state.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/ios/web_view/internal/sync/web_view_gcm_profile_service_factory.mm
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/services/network/proxy_resolving_socket_mojo_unittest.cc
[modify] https://crrev.com/365f6904890e5ee7e90f55189ab5d95b80bc3dbe/services/network/public/mojom/proxy_resolving_socket.mojom

Comment 5 by xunji...@chromium.org, Jul 26

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/838e1b1949af36aec49042cd1df6d55396d0957b

commit 838e1b1949af36aec49042cd1df6d55396d0957b
Author: Yoichi Osato <yoichio@chromium.org>
Date: Fri Jul 27 05:10:04 2018

Revert "Migrate gcm to network service's socket APIs"

This reverts commit 365f6904890e5ee7e90f55189ab5d95b80bc3dbe.

Reason for revert: UkmBrowserTest.SingleSyncSignoutCheck is Flaky
Findit identified the culprit r578386 with confidence 74.4%.

Original change's description:
> Migrate gcm to network service's socket APIs
> 
> With network service, net:: C++ socket access will need to be changed to using
> network service's socket APIs. This CL changes gcm to using
> proxy_resolving_socket.mojom instead of the C++ ProxyResolvingClientSocket.
> 
> GCM files that are changed:
> - google_apis/gcm/engine/connection_factory_impl.cc
>   This will request and own a network::mojom::ProxyResolvingSocketPtr
> - google_apis/gcm/engine/connection_handler_impl.cc
>   This will pass the mojo read/write pipes to socket streams.
> - google_apis/gcm/base/socket_stream.cc
>   SocketInputStream/SocketOutputStream will read from/write to mojo data pipes
>   instead of the C++ socket.
> 
> Network service changes
> - services/network/public/mojom/proxy_resolving_socket.mojom
>   Peer address is surfaced directly when connection is established. This is
>   needed to support GCM's use case. They need the peer address synchronously
>   when connection is done.
> 
> Browser changes:
> - NetworkContext raw mojo pointer has to be queried on the UI thread on demand.
>   Therefore changes are added to pass through a callback and ui task runner.
> 
> Bug:  862608 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Ic0c72c8ee7d9bc7deb6e8109234227f80ea3bbe3
> Reviewed-on: https://chromium-review.googlesource.com/1142344
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578386}

TBR=dcheng@chromium.org,peter@chromium.org,jam@chromium.org,sdefresne@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

Change-Id: I5951169891854c5d441d897dcb2e849f1ef7ace9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  862608 ,  868220 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1152589
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578539}
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/DEPS
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/fake_gcm_client.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/fake_gcm_client.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_client.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_client_impl.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_desktop_utils.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_driver_desktop.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_driver_desktop_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/components/gcm_driver/instance_id/BUILD.gn
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/DEPS
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/base/socket_stream.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/base/socket_stream.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_factory.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_factory_impl_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_handler.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_handler_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_handler_impl.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/fake_connection_factory.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/fake_connection_handler.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/engine/fake_connection_handler.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/google_apis/gcm/tools/mcs_probe.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/ios/web/browser_state.mm
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/ios/web/public/browser_state.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/ios/web_view/internal/sync/web_view_gcm_profile_service_factory.mm
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/services/network/proxy_resolving_socket_mojo_unittest.cc
[modify] https://crrev.com/838e1b1949af36aec49042cd1df6d55396d0957b/services/network/public/mojom/proxy_resolving_socket.mojom

Comment 7 by xunji...@chromium.org, Jul 27

Status: Assigned (was: Fixed)

Comment 8 by xunji...@chromium.org, Jul 27

Blockedon: 868220

Comment 9 by cduvall@chromium.org, Aug 6

Cc: cduvall@chromium.org

Comment 10 by xunji...@chromium.org, Aug 7 

I am back on 8/8. I will try to get this re-landed.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2

commit 5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Aug 10 20:37:24 2018

Revert "Revert "Migrate gcm to network service's socket APIs""

This reverts commit 838e1b1949af36aec49042cd1df6d55396d0957b.

Reason for revert: Reland after fix

Mojo doesn't allow dropping response callbacks (see
https://groups.google.com/a/chromium.org/forum/#!topic/services-dev/zSNh16-tkaA
for discussion). The fix is to modify
ProxyResolvingSocketFactory::CreateProxyResolvingSocket to always invoke
the response callback even when the underlying socket is destroyed.
This CL also adds a regression test in proxy_resolving_socket_mojo_unittest.cc.

TBR=dcheng@chromium.org
TBR=jam@chromium.org
TBR=sdefresne@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie9fdb93f965bbcf534253aaabe436c4de5f0666d

Bug:  862608 ,  868220 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie9fdb93f965bbcf534253aaabe436c4de5f0666d
Reviewed-on: https://chromium-review.googlesource.com/1169345
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582318}
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/DEPS
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/fake_gcm_client.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/fake_gcm_client.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_client.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_client_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_client_impl.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_client_impl_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_desktop_utils.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_desktop_utils.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_driver_desktop.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_driver_desktop_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/components/gcm_driver/instance_id/BUILD.gn
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/DEPS
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/base/socket_stream.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/base/socket_stream.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_factory.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_factory_impl_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_handler.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_handler_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_handler_impl.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/fake_connection_factory.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/fake_connection_handler.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/engine/fake_connection_handler.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/google_apis/gcm/tools/mcs_probe.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/ios/web/browser_state.mm
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/ios/web/public/browser_state.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/ios/web_view/internal/sync/web_view_gcm_profile_service_factory.mm
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/services/network/proxy_resolving_socket_mojo_unittest.cc
[modify] https://crrev.com/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2/services/network/public/mojom/proxy_resolving_socket.mojom

Comment 12 by xunji...@chromium.org, Aug 10

Status: Fixed (was: Assigned)
Hopefully this won't get reverted a second time :)
►

Sign in to add a comment