Issue metadata
Sign in to add a comment
|
Popup for <select> renders empty items if <select> is to narrow
Reported by
marius.g...@gmail.com,
Jul 11
|
||||||||||||||||||||||
Issue descriptionExample URL: https://jsbin.com/rasepukaru Steps to reproduce the problem: This issue only occurs on some Android devices. The one I used was a Huawei tablet, the MediaPad T3 10, which runs Android 7 with Huawei's customized UI. 1. Click the first select What is the expected behavior? A popup with the list of options should be shown, just like for the second select. What went wrong? The popup with the options shows, but the item labels are blank. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Does this work in other browsers? Yes Chrome version: 67.0.3396.87 Channel: stable OS Version: 7.0 Flash Version: We were alerted to this issue by two different customers that had trouble using our web app which includes narrow drop downs to choose hours and minutes. After some back & forth with one of the users we managed to pinpoint the issue to Chrome on at least the Huawei MediaPad T3 10. After getting our hands on a new MediaPad T3 10 I managed to reproduce the issue after upgrading from the preinstalled Chrome 61.0.3163.98, where the issue does not occur, to the current stable version. I realize that reproducing this is rather tedious, if there is anything we can do to help, don't hesitate to ask. Attached you'll find two videos, one of the popup being rendered faulty in Chrome 67 and one of the popup being rendered properly by Chrome 61.
,
Jul 12
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Launch Chrome. 2. Go to https://jsbin.com/rasepukaru>> Select output 3. Click 01 and observed that it is empty Chrome versions tested: 67.0.3396.87(Dev), 69.0.3489.0(Latest canary) OS: Android 7.0.0 Android Devices: Samsung Galaxy Tab S2 Using the per-revision bisect providing the bisect results, Good Build - 67.0.3373.0 Bad Build - 67.0.3374.0 You are looking for a change made after 543613(GOOD), but before 543614(BAD). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+/eba634331c440f4d0d716ff865f14a4be88013f7 @ asimjour: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Please navigate to below link for log's -- go/chrome-androidlogs/862594 Thanks!
,
Jul 12
,
Jul 12
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73221c336f865b79a8738f12f623d11568e28b0f commit 73221c336f865b79a8738f12f623d11568e28b0f Author: Amirhossein Simjour <asimjour@chromium.org> Date: Fri Jul 13 18:51:32 2018 Fix <select> popup width Fix typo in calculation of AnchoredPopupWindow's width. Bug: 862594 Change-Id: I0f79ca75c1d3c003d24dcba835fb6925b8d1dab5 Reviewed-on: https://chromium-review.googlesource.com/1136723 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#574999} [modify] https://crrev.com/73221c336f865b79a8738f12f623d11568e28b0f/ui/android/java/src/org/chromium/ui/widget/AnchoredPopupWindow.java
,
Jul 16
I verified that this has been fixed on Canary.
,
Jul 16
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 16
Is this change safe to merge into M68 at this point?
,
Jul 16
I believe this is safe. This is one line (one character to be exact) fix for a typo. After this change, instead of incorrectly using PaddingY to measure the width, we use PaddingX.
,
Jul 17
Please merge this as soon as possible. M68 stable cut is today.
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ce21735998d30374eb770710427ffa2d25a3d8f commit 4ce21735998d30374eb770710427ffa2d25a3d8f Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Jul 17 19:50:05 2018 Fix <select> popup width Fix typo in calculation of AnchoredPopupWindow's width. Bug: 862594 Change-Id: I0f79ca75c1d3c003d24dcba835fb6925b8d1dab5 Reviewed-on: https://chromium-review.googlesource.com/1136723 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#574999}(cherry picked from commit 73221c336f865b79a8738f12f623d11568e28b0f) Reviewed-on: https://chromium-review.googlesource.com/1140933 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#699} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/4ce21735998d30374eb770710427ffa2d25a3d8f/ui/android/java/src/org/chromium/ui/widget/AnchoredPopupWindow.java
,
Jul 17
This is fixed for M68.
,
Jul 19
Issue is verified on 68.0.3440.70
,
Jul 19
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by e...@chromium.org
, Jul 12