http/tests/misc/adopt-iframe-src-attr-after-remove.html |
||
Issue descriptionThe test http/tests/misc/adopt-iframe-src-attr-after-remove.html as always been a bit flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fadopt-iframe-src-attr-after-remove.html&testType=webkit_layout_tests The reason is that navigation triggered by a script before the onload handler don't generate back/forward entries. See third_party/blink/public/web/web_history_commit_type.h So of the test is fast enough, the history.back() may fails. It causes a timeout.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16edd27467d3490c9f7f46b2b6661d492e780c57 commit 16edd27467d3490c9f7f46b2b6661d492e780c57 Author: Arthur Sonzogni <arthursonzogni@chromium.org> Date: Mon Jul 30 08:58:42 2018 Fix test: http/tests/navigation/back-send-referrer.html The navigation may be triggered before the load event. When it happens, the history entry must replace the current one instead of being appended to it. Then history.go(-1) fails in the next document. This CL make the navigation to happen after the load event. Bug: 862580 , 831155 Change-Id: I4a48d50f5899e3fd65c74d9a89ab836ae94ba7be Reviewed-on: https://chromium-review.googlesource.com/1133261 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578998} [modify] https://crrev.com/16edd27467d3490c9f7f46b2b6661d492e780c57/third_party/WebKit/LayoutTests/http/tests/navigation/back-send-referrer.html
,
Jul 30
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f32e29a69aaeb7c3cb9a29835669cc8116ed404 commit 5f32e29a69aaeb7c3cb9a29835669cc8116ed404 Author: Arthur Sonzogni <arthursonzogni@chromium.org> Date: Mon Jul 30 09:42:52 2018 Fix 2 flaky blink layout tests. The test http/tests/misc/adopt-iframe-src-attr-after-remove.html as always been a bit flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fadopt-iframe-src-attr-after-remove.html&testType=webkit_layout_tests The reason is that navigations triggered by a script before the onload handler don't generate back/forward entries. See third_party/blink/public/web/web_history_commit_type.h Sometimes, this test was fast enough so that no history entry was created. Then history.back() failed and it ended with a timeout. This is the same for: http/tests/misc/resource-timing-iframe-restored-from-history.html Bug: 862580 , 831155 Change-Id: I3b8243c5f43c5043de8e23acfbe561a648c0f115 Reviewed-on: https://chromium-review.googlesource.com/1133170 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#579001} [modify] https://crrev.com/5f32e29a69aaeb7c3cb9a29835669cc8116ed404/third_party/WebKit/LayoutTests/fast/history/history-back-initial-vs-final-url.html [modify] https://crrev.com/5f32e29a69aaeb7c3cb9a29835669cc8116ed404/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html |
||
►
Sign in to add a comment |
||
Comment 1 by arthurso...@chromium.org
, Jul 11