New issue
Advanced search Search tips

Issue 862576 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 11
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Constraints broken in toolbar

Project Member Reported by gambard@chromium.org, Jul 11 
With UIRefresh flag enabled

What steps will reproduce the problem?
(1) Launch the app

What is the expected result?
Everything should be fine.

What happens instead?
In the debugger console, some constraints are broken. Also, from times to times, it is possible to see TabGrid image shrunk to the size of the label inside.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aab96631074ae44940c77dd9aee111473cfb38b7

commit aab96631074ae44940c77dd9aee111473cfb38b7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jul 11 14:23:02 2018

[iOS] Fix TabGrid toolbar button constraints

This CL removes the autolayout constraints on the TabGrid button in the
toolbar and instead positions it using frames.

Bug:  862576 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5eda2cc58ee38228e40870f723315bc91ac6953f
Reviewed-on: https://chromium-review.googlesource.com/1133167
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574153}
[modify] https://crrev.com/aab96631074ae44940c77dd9aee111473cfb38b7/ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm

Comment 2 by gambard@chromium.org, Jul 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment