New issue
Advanced search Search tips

Issue 862557 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 22
Cc:
stkhapugin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

Tapping on the side of the collapsed toolbar doesn't expand it

Project Member Reported by gambard@chromium.org, Jul 11 
With UI Refresh

What steps will reproduce the problem?
(1) Rotate to landscape
(2) Scroll to have the toolbar collapsed
(3) Tap on the side of the collapsed toolbar

What is the expected result?
The toolbar should expand.

What happens instead?
Nothing. It is working when tapping on the middle of the toolbar.

Comment 1 by stkhapugin@chromium.org, Jul 11

Cc: stkhapugin@chromium.org
Labels: -Pri-1 -MS-Omnibox MS-Adaptive-Toolbar Pri-2
Owner: gambard@chromium.org
I don't think it's a P1. Also the tap is outside of the location bar, so I guess toolbar needs to handle this.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1

commit 59dfb241b6bc74963bada8fa7c8ce42b250c6ad1
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Aug 22 14:27:15 2018

[iOS] Exit fullscreen when tapping the collapsed toolbar

This CL makes sure that it is possible to exit fullscreen by tapping the
collapsed toolbar.
For now, it is possible to exit it by tapping the steady view.

Bug:  862557 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I31667dd679d1b38f41d819197aedc54c76024ab4
Reviewed-on: https://chromium-review.googlesource.com/1184912
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585010}
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/59dfb241b6bc74963bada8fa7c8ce42b250c6ad1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller_delegate.h

Comment 3 by gambard@chromium.org, Aug 22

Status: Fixed (was: Assigned)

Comment 4 by srikanthg@chromium.org, Aug 29

Status: Verified (was: Fixed)
Verified on M70.0.3536.0 canary. iOS12.0 beta#11 iPhone7 Plus.
►

Sign in to add a comment