New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 20 days ago
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Ctrl+z ' command does not work on search box on 'chrome://settings/passwords'.

Reported by pranjali...@etouch.net, Jul 11

Issue description

Chrome version : 68.0.3440.59 (Official Build) d2bc7dee8086bc46fe6153b4b8c45da429245503-refs/branch-heads/3440@{#644}(32/64-bit) 

OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/'.
2. Type any alphabate in search box ,press 'ctrl+a'(such that text get selected) and press 'ctrl+x'.
3. Now press 'ctrl+z' and observe.

Actual Result: Text does not appear after pressing ctrl+z command on search textbox on  'chrome://settings/passwords'.
Expected Result: Text should appear after pressing ctrl+z command on search textbox on  'chrome://settings/passwords'.

This is a regression issue broken in ‘M-63’ and below is bisect info.
Good build: 63.0.3225.0
Bad build: 63.0.3226.0

You are probably looking for a change made after 504658 (known good), but no later than 504659 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/88d078811e5743304ab4407d01e401ac1b77948e..3bc5e2682778f84572efc5bf4383b34d5c48e699

Suspect: https://chromium.googlesource.com/chromium/src/+/3bc5e2682778f84572efc5bf4383b34d5c48e699

@jdoerrie: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You
 
Actual_result.mp4
328 KB View Download
Expected_result.mp4
228 KB View Download
Cc: maxwalker@chromium.org
I'm inclined to mark this a WontFix, as we now deliberately use CTRL+Z to undo deletion of passwords. While I suppose we could change the behavior of CTRL+Z depending on which part of the page has focus, I believe this would be confusing for users. Furthermore, I do believe that undoing a password deletion is more important than undoing the cut of a search query, especially considering that CTRL+V is another suitable workaround.

+maxwalker@ to add feedback from a UX perspective.
Ideally Undo would refer to all previous operations on the passwords page (multiple Undo). For example, if a user first deletes a password and then enters and deletes text in the search field, Undo should first restore the deleted text in the search field and then restore the deleted password. I think this wouldn't be confusing since the outcome of undoing an operation is always visible (for example a restored password reappears in the passwords list).

Interesting observation 1: it seems like clicking the Undo command (in the macOS menu bar) already does restore text in the search field while the keyboard shortcut doesn't. See attached screencast.

Interesting observation 2: the same is true for the global Settings search field which doesn't react to the keyboard shortcut either.
Undo.gif
3.0 MB View Download
Cc: jdoerrie@chromium.org vasi...@chromium.org
Owner: rsgingerrs@chromium.org
Yue, PTAL. I think https://crbug.com/778569 can also be related.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733deb1b6ea7b21213af40252ed486ce46abf3e5

commit 733deb1b6ea7b21213af40252ed486ce46abf3e5
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Sep 18 00:29:12 2018

Password manager: Ctrl+z command should work on search box.

The expected behavior is that the keyboard event goes first to the
focused editable element. Since it handles the event, the event won't
be processed anymore. If no editable element is focused, the event is
handled by the password handler.

Bug:  862554 
Change-Id: I5286c61891504d410d08004c2caf6055d96ea0af
Reviewed-on: https://chromium-review.googlesource.com/1208820
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591895}
[modify] https://crrev.com/733deb1b6ea7b21213af40252ed486ce46abf3e5/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/733deb1b6ea7b21213af40252ed486ce46abf3e5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/733deb1b6ea7b21213af40252ed486ce46abf3e5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Labels: TE-Verified-M71 TE-Verified-71.0.3556.0
Update:

Rechecked the above issue using on latest canary build#71.0.3556.0 on Windows(7,8,8.1.10) ,Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and issue is fixed.

Please refer attached screencast.

Thank You..

Canary Behaviour.mp4
204 KB View Download
Status: Fixed (was: Assigned)
Marked as fixed.

Sign in to add a comment