Regression: Print-Preview first page is seen blank in full-screen mode.
Reported by
aiman.an...@etouch.net,
Jul 11
|
|||||||
Issue descriptionChrome Version: 69.0.3488.0 (Official Build) Revision 8da4193c988f8252c21a1aace196644ab0929268-refs/branch-heads/3488@{#1}(32/64-bit). OS: Mac(10.12.6,10.13.1,10.13.6,10.14.0), Windows(7,8,8.1,10) and Linux(14.04 LTS) OS. What steps will reproduce the problem? 1. Launch chrome, navigate to https://permission.site and click on 'Full Screen' option. 2. In Full-Screen mode give print command and observe the print preview. Actual: First page of print-preview is seen blank.(Content is seen from 2nd page on print preview.) Expected: Blank page should not be seen on print-preview. This is a Regression issue, broken in 'M69', below is per-revision bisect info: Good Build: 69.0.3446.0(Revision:563012) Bad Build: 69.0.3447.0(Revision:563478) You are probably looking for a change made after 563064 (known good), but no later than 563065 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fbf576282bc9b2281a6a2299883ef910c5d71e70..14eeb1d5b6369a4fefa57973bf6b646469f72e35 Suspect: https://chromium.googlesource.com/chromium/src/+/14eeb1d5b6369a4fefa57973bf6b646469f72e35 dtapuska@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on Dev build #69.0.3486.0 Kindly review the attached screen-cast. Thank You!
,
Jul 11
Put together a site fix here: https://github.com/chromium/permission.site/pull/47
,
Jul 19
,
Jul 19
Looks like there's a problem with the workaround listed in #2 so I'm guessing there's some lingering issue with fullscreen rendering, which may also be affecting issue 849569 due to the suspect CL identified in #1. Chris, do you think these are related?
,
Jul 19
,
Jul 20
I'm confused about the status of this bug. Dave, would you mind clarifying? It appears that a page that used to work is now blank, due to the CL in #1. Is that WAI due to a bug on the page? Dave wrote about this in issue 849569 (which is not externally visible, so repeating it here): "... just about printing and it inserts a blank page because of the min-height on the html element. If this is removed it prints fine. The printing code is quite different than the normal display code I believe." Thanks!
,
Jul 20
This bug is about an extra blank page being inserted during printing. This is caused by the min-height being set on the html element. I've put a pull request for the site to fix the issue and it has been merged. But permission.site hasn't pulled the latest content yet. The min-height on the html element was necessary to work around another bug with fullscreen so really it shouldn't be there. The layout engine is giving the HTML element sizing and when it prints it prints all of the individual layers it seems. So the top layer elements are being printed after the HTML element. If the HTML element doesn't have min-height it works correctly.
,
Jul 20
,
Sep 12
css change on permission.site has been deployed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aiman.an...@etouch.net
, Jul 11