Most visited tiles in tabswitcher mode are misaligned on changing the device orientation from landscape to portrait mode. |
|||||||||
Issue descriptionApp Version: 69.0.3487.0 canary iOS Version: 10.3.3,iOS 11 Device: iPhones only Steps to reproduce: 1. Launch Chrome. 2. Open few normal tabs. 3. Change the device orientation to landscape mode. 4. Tap on tabswithcer icon. 5. Swipe the screen to Recent tabs. 6. Tap on Show full history 7. Change the device orientation Portrait mode and back to landscape mode. 8. Tap on Done on History screen. Observed results: Most visited icons are seen in Recent tabs screen. Expected results: Most visited icons should not be seen. Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA, New UI in M69 Bug reproducible on the current beta channel build : NA, New UI in M69 Link to video/image: https://drive.google.com/file/d/1asAVkqzRPR-jNadbiRtKIw4FZhV5xVJp/view?usp=sharing
,
Jul 17
,
Jul 17
,
Jul 17
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1b22872e1807a2757589b15f20e8c956b7e54f9 commit a1b22872e1807a2757589b15f20e8c956b7e54f9 Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed Jul 25 03:55:04 2018 [ios] Fix TabGrid ScrollView Offset When Rotating Underneath History Move offset calculation away from -viewDidLayoutSubviews and into -viewDidAppear and -viewWillTransitionIntoSize so that the logic lies in places where the newly rotated frame has been defined. -viewDidAppear covers first-time calculations and -viewWillTransitionIntoSize handles rotations. Video: https://drive.google.com/open?id=1ziE4y_N4FYZuR5cR10i-wuJ1Zkmqzdyv Bug: 862544 Change-Id: Ib493e7395041d498abb5b77d6c8732dc443b01e3 Reviewed-on: https://chromium-review.googlesource.com/1141287 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#577795} [modify] https://crrev.com/a1b22872e1807a2757589b15f20e8c956b7e54f9/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/a1b22872e1807a2757589b15f20e8c956b7e54f9/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 25
,
Jul 25
,
Jul 26
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
Change verified as of 7/26
,
Jul 26
Approved!
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9bd130f35a0b8b1b6b38a4c7dfdb5fad27c78b commit 8d9bd130f35a0b8b1b6b38a4c7dfdb5fad27c78b Author: sczs <sczs@chromium.org> Date: Thu Jul 26 23:44:49 2018 [ios] Fix TabGrid ScrollView Offset When Rotating Underneath History Move offset calculation away from -viewDidLayoutSubviews and into -viewDidAppear and -viewWillTransitionIntoSize so that the logic lies in places where the newly rotated frame has been defined. -viewDidAppear covers first-time calculations and -viewWillTransitionIntoSize handles rotations. Video: https://drive.google.com/open?id=1ziE4y_N4FYZuR5cR10i-wuJ1Zkmqzdyv TBR=thegreenfrog@chromium.org (cherry picked from commit a1b22872e1807a2757589b15f20e8c956b7e54f9) Bug: 862544 Change-Id: Ib493e7395041d498abb5b77d6c8732dc443b01e3 Reviewed-on: https://chromium-review.googlesource.com/1141287 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577795} Reviewed-on: https://chromium-review.googlesource.com/1152489 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#134} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8d9bd130f35a0b8b1b6b38a4c7dfdb5fad27c78b/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/8d9bd130f35a0b8b1b6b38a4c7dfdb5fad27c78b/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 31
Verified in 70.0.3508.0 Canary, iPhone X iOS 11.4.1, iPhone 6 iOS10.3.3 Looks good.
,
Aug 1
Verified in: App Version: 69.0.3497.22 beta Devices: iPhone 7 Plus, iPhone 6 Plus iOS Versions: 10.3.3, 11.4.1 Shows Recent Tabs view on changing the device orientation of device underneath history. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by marq@chromium.org
, Jul 13Labels: -Pri-2 M-69 Q2 Pri-1
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)